Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stores of other services available via PreHandleContext #6178

Closed
netopyr opened this issue Apr 19, 2023 · 2 comments · Fixed by #6210, #6230, #6238, #6239 or #6240
Closed

Make stores of other services available via PreHandleContext #6178

netopyr opened this issue Apr 19, 2023 · 2 comments · Fixed by #6210, #6230, #6238, #6239 or #6240
Assignees
Labels
Modularization Issues or PRs related to modularization

Comments

@netopyr
Copy link
Contributor

netopyr commented Apr 19, 2023

  • Add ReadableStores that allows to create any kind of store. (First version will be hard-coded.)
  • Integrate ReadableStores in PreHandleContext and QueryContext.
  • Make TransactionHandler.preHandle() expect only the context.
@netopyr netopyr added the Modularization Issues or PRs related to modularization label Apr 19, 2023
@netopyr netopyr self-assigned this Apr 19, 2023
@nickpoorman
Copy link
Contributor

nickpoorman commented Apr 19, 2023

@netopyr Will this allow one service to call another service's readable store in handle? For example, Freeze Service - freezeUpgrade needs to be able to call Network Service - getFileContent to get the upgrade file.

@netopyr
Copy link
Contributor Author

netopyr commented Apr 20, 2023

This issues will build the base and integrate it with the pre-handle and query workflow only. We are just starting to re-design the handle workflow, therefore it is too early to do any modifications right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment