Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize cross service stores #6246

Merged
merged 4 commits into from Apr 28, 2023
Merged

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Apr 25, 2023

This finalizes the changes in the pre-handle workflow, that makes stores available across services:

  • AccountAccess removed
  • PreHandleContext becomes interface, FakePreHandleContext and PreHandleContextImpl updated accordingly
  • Removed default implementation of TransactionDispatcher.preHandle()

…nDispatcher simplified

Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr netopyr added the Modularization Issues or PRs related to modularization label Apr 25, 2023
@netopyr netopyr added this to the v0.38 milestone Apr 25, 2023
@netopyr netopyr self-assigned this Apr 25, 2023
@netopyr netopyr changed the title AccountAccess removed, PreHandleContext becomes interface, Transactio… Finalize cross service stores Apr 25, 2023
@netopyr netopyr linked an issue Apr 25, 2023 that may be closed by this pull request
# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/TransactionDispatcher.java
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr netopyr marked this pull request as ready for review April 28, 2023 10:27
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@github-actions
Copy link

Node: Unit Test Results

  1 335 files    1 335 suites   1h 12m 41s ⏱️
97 387 tests 97 379 ✔️ 8 💤 0
99 019 runs  99 011 ✔️ 8 💤 0

Results for commit df45eee.

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.4% 50.4% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Node: Integration Test Results

    3 files      3 suites   15m 35s ⏱️
151 tests 151 ✔️ 0 💤 0
152 runs  152 ✔️ 0 💤 0

Results for commit df45eee.

@github-actions
Copy link

Node: E2E Test Results

    1 files      1 suites   17m 8s ⏱️
309 tests 309 ✔️ 0 💤 0
327 runs  327 ✔️ 0 💤 0

Results for commit df45eee.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@netopyr netopyr merged commit 9c1fe6d into develop Apr 28, 2023
9 of 11 checks passed
@netopyr netopyr deleted the 06178-finalize-cross-service-stores branch April 28, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Modularization Issues or PRs related to modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make stores of other services available via PreHandleContext
2 participants