Implement ContractUpdateHandler.handle #9379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
vtronkov
requested review from
netopyr,
tinker-michaelj and
Neeharika-Sompalli
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #9379 +/- ##
=============================================
- Coverage 65.26% 65.22% -0.04%
- Complexity 29678 29680 +2
=============================================
Files 3262 3262
Lines 124581 124659 +78
Branches 12918 12947 +29
=============================================
+ Hits 81310 81314 +4
- Misses 40194 40271 +77
+ Partials 3077 3074 -3
☔ View full report in Codecov by Sentry. |
# Conflicts: # hedera-node/hedera-token-service/src/main/java/com/hedera/node/app/service/token/api/TokenServiceApi.java
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Show resolved
Hide resolved
...rvice-impl/src/main/java/com/hedera/node/app/service/token/impl/api/TokenServiceApiImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Valentin Tronkov <valentin.tronkov@limechain.tech>
… a method Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
…ecks from preHandle Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
vtronkov
added
Limechain
Signed-off-by: Valentin Tronkov <valentin.tronkov@limechain.tech>
...-clients/src/main/java/com/hedera/services/bdd/suites/contract/hapi/ContractUpdateSuite.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Show resolved
Hide resolved
...main/java/com/hedera/node/app/service/contract/impl/records/ContractUpdateRecordBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <valentin.tronkov@limechain.tech>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
…le2' into 08623_ContractUpdateHandler-handle2
Neeharika-Sompalli
approved these changes
Nov 3, 2023
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Show resolved
Hide resolved
.../src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
Show resolved
Hide resolved
4 tasks
2 tasks
imalygin
pushed a commit
that referenced
this pull request
Nov 13, 2023
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com> Signed-off-by: Valentin Tronkov <valentin.tronkov@limechain.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #8623