Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ContractUpdateSuite and address ContractUpdateHandle comments #9847

Merged
merged 14 commits into from Nov 14, 2023
Merged

Fix ContractUpdateSuite and address ContractUpdateHandle comments #9847

merged 14 commits into from Nov 14, 2023

Conversation

vtronkov
Copy link
Contributor

@vtronkov vtronkov commented Nov 13, 2023 •
edited

Description:
Adding additional validations and unit tests

Related issue(s):

Fixes #9654
Fixes #8996

Notes for reviewer:
Node: Since I did some refactoring the changes made for this PR are not so clear - I will annotate them with Github comments.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@vtronkov
feat: add staking elections validation
c118442 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
fix: calling the update staking election validation instead of the cr…
8b553b4 
…eate one

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
feature: add auto associations validation
5ad7a79 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
feature: update onlyAffectsExpiry check
60160e6 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
feature: add new validation and enable a test
d754d90 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
fix: incorrect validation
2fa659b 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
test: initial unit tests
32e4048 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
refactor: move validations from update to validateSemantics
ff73aba 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
refactor: reorder methods
0445e52 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
refactor: reuse variable
d7492e0 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
test: finish unit tests
363c232 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov vtronkov changed the title 09654 08996 fix contract update suite and address comments Fix ContractUpdateSuite and address ContractUpdateHandle comments Nov 13, 2023
@vtronkov vtronkov self-assigned this Nov 13, 2023
@vtronkov vtronkov added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Nov 13, 2023
@vtronkov vtronkov marked this pull request as ready for review November 13, 2023 11:13
@vtronkov
Merge branch 'develop' into 09654_08996-fix-ContractUpdateSuite-and-a…
d84318a 
…ddress-comments

# Conflicts:
#	hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
@vtronkov
test: fix compile error
27eedc2 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
test: enable passing test
ed4d17b 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

Node: Unit Test Results

    2 278 files  +  1      2 278 suites  +1   1h 27m 44s ⏱️ +57s
118 357 tests +30  118 323 ✔️ +30  34 💤 ±0  0 ❌ ±0 
126 618 runs  +30  126 584 ✔️ +30  34 💤 ±0  0 ❌ ±0 

Results for commit ed4d17b. ± Comparison against base commit d9b49d5.

@github-actions GitHub Actions
Copy link

Node: E2E Test Results

    1 files      1 suites   22m 1s ⏱️
312 tests 312 ✔️ 0 💤 0 ❌
334 runs  334 ✔️ 0 💤 0 ❌

Results for commit ed4d17b.

@github-actions GitHub Actions
Copy link

Node: Integration Test Results

280 tests   280 ✔️  28m 30s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit ed4d17b.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited

Node: HAPI Test Results

1 246 tests   869 ✔️  1h 31m 41s ⏱️
   166 suites  377 💤
   166 files        0 ❌

Results for commit ed4d17b.

♻️ This comment has been updated with latest results.

@vtronkov vtronkov mentioned this pull request Nov 14, 2023
Closed
tinker-michaelj
tinker-michaelj approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, tyvm @vtronkov !

@tinker-michaelj tinker-michaelj merged commit 9bf77c0 into develop Nov 14, 2023
14 of 15 checks passed
@tinker-michaelj tinker-michaelj deleted the 09654_08996-fix-ContractUpdateSuite-and-address-comments branch November 14, 2023 16:18
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@vtronkov @nickpoorman
Fix ContractUpdateSuite and address ContractUpdateHandle comments (#9847
345dcef 
)

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@iwsimon iwsimon Awaiting requested review from iwsimon iwsimon is a code owner automatically assigned from hashgraph/hedera-services

@acuarica acuarica Awaiting requested review from acuarica acuarica is a code owner automatically assigned from hashgraph/hedera-smart-contracts

Assignees

@vtronkov vtronkov

Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address ContractUpdateHandler review comments Fix ContractUpdateSuite tests
2 participants
@vtronkov @tinker-michaelj