New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TokenInfoHTSSuite tests #9509
Conversation
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #9509 +/- ##
=============================================
+ Coverage 65.26% 65.29% +0.02%
- Complexity 29678 29685 +7
=============================================
Files 3262 3260 -2
Lines 124581 124575 -6
Branches 12918 12919 +1
=============================================
+ Hits 81310 81342 +32
+ Misses 40194 40157 -37
+ Partials 3077 3076 -1
☔ View full report in Codecov by Sentry. |
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @MiroslavGatsanoga, very cool to see these tests passing. 🙌
I don't think we actually need to pass in the MessageFrame
to these HtsCall
implementations, however.
- The
ProxyWorldUpdater
's method to externalize system contract result just directly calls anEnhancement
method; and theHtsCall
implementations already have access to theEnhancement
. - For mono-service compatibility, we don't want to skip externalizing the result for any
static
frame, but only if we are in aContractCallLocalQuery
instead of a HAPI transaction; compare here in mono-service.
I think we just need to make the QuerySystemContractOperations
method here a no-op; and then remove the MessageFrame
injections. 🤔
method no-op Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Will push the updates shortly, tyvm @tinker-michaelj! |
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty @MiroslavGatsanoga
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Description:
Fix child record issues related to token info precompile, making
TokenInfoHTSSuite
passing as a result.Also enable a couple of tests in
DefaultTokenStatusSuite
since changes to read-only precompiles are related to them.Related issue(s):
#9427
Notes for reviewer:
Checklist