Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditional, enriched records of read-only HTS system contract calls. #9427

Closed
2 tasks
Tracked by #9461
, #9420
...
tinker-michaelj opened this issue Oct 24, 2023 · 2 comments · Fixed by #9844 or #9931
Closed
2 tasks
Tracked by #9461
, #9420
...

Unconditional, enriched records of read-only HTS system contract calls. #9427

tinker-michaelj opened this issue Oct 24, 2023 · 2 comments · Fixed by #9844 or #9931
Assignees
@MiroslavGatsanoga @ilko-iliev-lime
Labels
Limechain Work planned for the LimeChain team

Comments

@tinker-michaelj
Copy link
Collaborator

tinker-michaelj commented Oct 24, 2023 •
edited
Loading

Validate the below happy path scenarios:

  • For a respectable sampling of (5-6 different) read-only system contracts, the synthetic ContractCallResults found on their success records match those from mono-service.

And the failure scenarios:

  • For a respectable sampling of (5-6 different) of read-only system contracts, the synthetic ContractCallResults found on their unsuccessful records match those from mono-service.
@tinker-michaelj tinker-michaelj mentioned this issue Oct 24, 2023
Closed
10 tasks
@MiroslavGatsanoga MiroslavGatsanoga mentioned this issue Oct 25, 2023
Closed
@yosiftouma yosiftouma added the Limechain Work planned for the LimeChain team label Oct 25, 2023
@MiroslavGatsanoga MiroslavGatsanoga mentioned this issue Oct 26, 2023
Merged
2 tasks
@MiroslavGatsanoga
Copy link
Collaborator

#9509 covered the following scenarios:

  • TokenInfoHTSSuite
    • Happy path scenarios covered
      • HAPI_GET_TOKEN_INFO
      • HAPI_GET_FUNGIBLE_TOKEN_INFO
      • HAPI_GET_NON_FUNGIBLE_TOKEN_INFO
      • HAPI_GET_TOKEN_CUSTOM_FEES
    • No failure scenarios asserted
  • DefaultTokenStatusSuite
    • Happy path scenarios covered
      • GET_TOKEN_DEFAULT_FREEZE_STATUS
      • GET_TOKEN_DEFAULT_KYC_STATUS
    • No failure scenarios asserted

This was referenced Nov 8, 2023
Closed
Merged
@ilko-iliev-lime
Copy link
Contributor

ilko-iliev-lime commented Nov 13, 2023 •
edited
Loading

Read-only calls covered:

  • TypeCheckCall: Issues fixed in the following PR.
  • IsTokenCall: Issues fixed in the following PR.
  • IsKycCall: No issues found
  • IsFrozenCall: No issues found
  • GetApprovedCall: No issues found
  • GetAllowanceCall: Missing the INVALID_ACCOUNT_ID status on non-static calls. Mod output doesn't match with mono.

@ilko-iliev-lime ilko-iliev-lime mentioned this issue Nov 16, 2023
Merged
2 tasks
ilko-iliev-lime added a commit that referenced this issue Nov 20, 2023
@ilko-iliev-lime
#9427: Revert after INVALID_ACCOUNT_ID static call (#9931)
6582f75 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
@thenswan thenswan mentioned this issue Nov 22, 2023
Closed
4 tasks
nickpoorman pushed a commit that referenced this issue Nov 22, 2023
@ilko-iliev-lime @nickpoorman
#9427: Revert after INVALID_ACCOUNT_ID static call (#9931)
9138153 
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiroslavGatsanoga MiroslavGatsanoga

@ilko-iliev-lime ilko-iliev-lime

Labels
Limechain Work planned for the LimeChain team
Projects
Services Team
Archived in project
Milestone
No milestone
4 participants
@MiroslavGatsanoga @tinker-michaelj @yosiftouma @ilko-iliev-lime