Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9559 Increased timeout in the assertions to prevent non-deterministic failures. #9560

Merged
merged 1 commit into from Nov 1, 2023

Conversation

imalygin
Copy link
Member

Description:

Increased a timeout in MerkleDbCompactionCoordinatorTest#assertCompactable and MerkleDbCompactionCoordinatorTest#testCompactionFailed to prevent non-deterministic failures

Related issue(s):

Fixes #9559

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

… failures.

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
@github-actions
Copy link

Node: Unit Test Results

    2 259 files      2 259 suites   1h 25m 46s ⏱️
118 232 tests 118 198 ✔️ 34 💤 0
126 491 runs  126 457 ✔️ 34 💤 0

Results for commit 1e44d69.

@codecov
Copy link

codecov bot commented Oct 27, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@github-actions
Copy link

Node: E2E Test Results

    1 files      1 suites   20m 59s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 1e44d69.

@github-actions
Copy link

Node: Integration Test Results

280 tests   280 ✔️  32m 53s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 1e44d69.

@github-actions
Copy link

Node: HAPI Test Results

1 228 tests   748 ✔️  1h 14m 8s ⏱️
   165 suites  480 💤
   165 files        0

Results for commit 1e44d69.

@imalygin imalygin merged commit 3747a57 into develop Nov 1, 2023
10 of 11 checks passed
@imalygin imalygin deleted the 9559-assert-timeout-increase branch November 1, 2023 17:27
petreze pushed a commit that referenced this pull request Nov 2, 2023
… failures. (#9560)

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@imalygin imalygin mentioned this pull request Nov 3, 2023
2 tasks
imalygin added a commit that referenced this pull request Nov 13, 2023
… failures. (#9560)

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test in MerkleDbCompactionCoordinatorTest may fail non-deterministically
2 participants