9559 Improved asserts for latches. #9669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
imalygin
force-pushed
the
9559-stabilized-test
branch
from
d99b57a
to
cd487b5
Compare
artemananiev
approved these changes
Nov 3, 2023
OlegMazurov
approved these changes
Nov 6, 2023
Ivo-Yankov
pushed a commit
that referenced
this pull request
Nov 9, 2023
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com> Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a follow up for #9560. Clearly, insufficient timeout was not the reason for that non-deterministic failure.
To stabilize the test I added asserts happening in the main thread for latches. If it fails, it'll be easier to pinpoint where exactly the failure is.
Related issue(s):
Fixes #9559
Checklist