Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E2E tests in TokenUpdatePrecompileSuite #9625

Merged
merged 25 commits into from Nov 8, 2023
Merged

Fix E2E tests in TokenUpdatePrecompileSuite #9625

merged 25 commits into from Nov 8, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Nov 2, 2023

Description:
This PR fixes TokenUpdatePrecompileSuite e2e tests. Some changes were also needed in how we attach the child records and some additional handles inside TokenKeyCall in order to catch some of the corner cases

Related issue(s):

Fixes #9566

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

MiroslavGatsanoga and others added 12 commits October 26, 2023 16:40
@MiroslavGatsanoga
Fix TokenInfoHTSSuite tests
a369797 
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga
Merge branch 'develop' into fix-token-info-hts-suite
98d5403
@MiroslavGatsanoga
Move fix for child records to AbstractNonRevertibleTokenViewCall
18f035b 
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga
Remove unused mock
c884415 
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga
Setup mock message frame with mock proxy updater
432b9c6 
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga
Fix copy-paste error in DefaultKycStatusCallTest
378e035 
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga
Merge branch 'develop' into fix-token-info-hts-suite
c379a62
@MiroslavGatsanoga
Enable a couple of tests in DefaultTokenStatusSuite
c750cb7 
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga
Revert MessageFrame injections and make QuerySystemContractOperations
7547749 
method no-op

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga
Fix failing unit test
d6c44e9 
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga
Merge branch 'develop' into fix-token-info-hts-suite
04a9c7f
@petreze
fix UpdatePrecompileSuite tests and enhance child records behaviour
e442139 
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze petreze requested review from a team and tinker-michaelj as code owners November 2, 2023 14:26
@petreze petreze marked this pull request as draft November 2, 2023 14:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited

Node: Unit Test Results

    2 272 files  ±0      2 272 suites  ±0   1h 26m 46s ⏱️ + 1m 55s
118 348 tests ±0  118 314 ✔️ +1  34 💤 ±0  0 ❌  - 1 
126 609 runs  ±0  126 575 ✔️ +1  34 💤 ±0  0 ❌  - 1 

Results for commit 3839a6d. ± Comparison against base commit 5d44593.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   21m 12s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
332 runs  332 ✔️ 0 💤 0 ❌

Results for commit 3839a6d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   32m 41s ⏱️ ±0s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 3839a6d. ± Comparison against base commit 5d44593.

♻️ This comment has been updated with latest results.

@petreze
Merge branch 'develop' into 09566-token-update-suite
49a469e 
# Conflicts:
#	hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/scope/HandleSystemContractOperations.java
#	hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/scope/QuerySystemContractOperations.java
#	hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/systemcontracts/hts/AbstractNonRevertibleTokenViewCall.java
#	hedera-node/hedera-smart-contract-service-impl/src/test/java/com/hedera/node/app/service/contract/impl/test/exec/scope/QuerySystemContractOperationsTest.java
@petreze petreze self-assigned this Nov 2, 2023
@petreze petreze marked this pull request as ready for review November 2, 2023 15:28
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@5d44593). Click here to learn what that means.

❗ Current head 6eb51bc differs from pull request most recent head 3839a6d. Consider uploading reports for the commit 3839a6d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #9625   +/-   ##
==========================================
  Coverage           ?   65.28%           
  Complexity         ?    29703           
==========================================
  Files              ?     3261           
  Lines              ?   124649           
  Branches           ?    12924           
==========================================
  Hits               ?    81379           
  Misses             ?    40191           
  Partials           ?     3079

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mustafauzunn mustafauzunn added the Limechain Work planned for the LimeChain team label Nov 6, 2023
@petreze
fix misleading typo
84ba2a6 
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze
Merge branch 'develop' into 09566-token-update-suite
8e48cae
@petreze
apply spotless
297d899 
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
kimbor
kimbor previously approved these changes Nov 6, 2023
View reviewed changes
agadzhalov
agadzhalov previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MrValioBg
MrValioBg previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@MrValioBg MrValioBg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work 💯

@petreze petreze dismissed stale reviews from MrValioBg, agadzhalov, and kimbor via 3839a6d November 7, 2023 19:23
dikel
dikel approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@dikel dikel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tinker-michaelj
tinker-michaelj approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, LGTM!

@petreze petreze merged commit 98676e5 into develop Nov 8, 2023
14 of 15 checks passed
@petreze petreze deleted the 09566-token-update-suite branch November 8, 2023 14:49
@petreze petreze mentioned this pull request Nov 8, 2023
Merged
2 tasks
Ivo-Yankov pushed a commit that referenced this pull request Nov 9, 2023
@petreze @MiroslavGatsanoga @Ivo-Yankov
Fix E2E tests in TokenUpdatePrecompileSuite (#9625)
c8f7ef3 
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Co-authored-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@petreze @MiroslavGatsanoga @nickpoorman
Fix E2E tests in TokenUpdatePrecompileSuite (#9625)
22563e8 
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Co-authored-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dikel dikel dikel approved these changes

@MrValioBg MrValioBg MrValioBg approved these changes

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@agadzhalov agadzhalov agadzhalov approved these changes

@povolev15 povolev15 Awaiting requested review from povolev15 povolev15 is a code owner automatically assigned from hashgraph/hedera-services

@lukelee-sl lukelee-sl Awaiting requested review from lukelee-sl lukelee-sl is a code owner automatically assigned from hashgraph/hedera-smart-contracts

@MiroslavGatsanoga MiroslavGatsanoga Awaiting requested review from MiroslavGatsanoga

@mustafauzunn mustafauzunn Awaiting requested review from mustafauzunn

@kimbor kimbor Awaiting requested review from kimbor

Assignees

@petreze petreze

Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix E2E tests in TokenUpdatePrecompileSuite
8 participants
@petreze @kimbor @dikel @MrValioBg @tinker-michaelj @agadzhalov @mustafauzunn @MiroslavGatsanoga