Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix develop while adding responseCode as the additional required parameter #9768

Merged
merged 1 commit into from Nov 8, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Nov 8, 2023

Description:
Fix develop after merging PR1 and PR2 because of the related changes in those two PRs

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…meter

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze petreze requested review from tinker-michaelj and a team as code owners November 8, 2023 15:18
@petreze petreze requested a review from acuarica November 8, 2023 15:18
@petreze petreze changed the title fix develop while adding responseCode as the additional required parameter Fix develop while adding responseCode as the additional required parameter Nov 8, 2023
@petreze petreze self-assigned this Nov 8, 2023
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tinker-michaelj tinker-michaelj merged commit 527b92a into develop Nov 8, 2023
10 of 11 checks passed
@tinker-michaelj tinker-michaelj deleted the fix-revertible-externalization branch November 8, 2023 15:31
Ivo-Yankov pushed a commit that referenced this pull request Nov 9, 2023
…meter (#9768)

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
…meter (#9768)

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants