Fix ApproveAllowanceSuite tests #9649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
# Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/systemcontracts/hts/AbstractNonRevertibleTokenViewCall.java
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Node: E2E Test Results 1 files ± 0 1 suites ±0 21m 18s ⏱️ + 21m 18s Results for commit 894c7bb. ± Comparison against base commit 2f890ea. This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
2 tasks
...p/service/contract/impl/exec/systemcontracts/hts/grantapproval/ClassicGrantApprovalCall.java
Outdated
Show resolved
Hide resolved
tinker-michaelj
requested changes
Nov 8, 2023
There was a problem hiding this comment.
Overall great work! 🙌
Two items:
- (Blocking) We need to re-create
EncodingFacadeutilities incontract-service-implso we don't have lingering dependencies on mono-service. - (Nice-to-have) Can we add to the
HtsCallinterface a default method,
default PricedResult execute(MessageFrame frame) {
return execute();
}
so this PR doesn't have to change all the files for HtsCall implementations that don't actually need the MessageFrame?
# Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/systemcontracts/hts/AbstractRevertibleTokenViewCall.java
…d a default method to the HtsCall interface; reverted changes in unit tests Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
|
Hey @tinker-michaelj, I've addressed your points 🙂 |
tinker-michaelj
approved these changes
Nov 9, 2023
ilko-iliev-lime
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech> Co-authored-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com>
4 tasks
nickpoorman
pushed a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech> Co-authored-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix ApproveAllowanceSuite tests
Related issue(s):
Fixes #9357