Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed canUseEip1014AliasesForXfers and updateMaxAutoAssociationsWorks #9667

Merged
merged 6 commits into from Nov 6, 2023

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented Nov 3, 2023

Description:

Related issue(s):

Fixes #9659
Fixed #9635

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
@iwsimon iwsimon requested review from a team as code owners November 3, 2023 19:15
@iwsimon iwsimon self-assigned this Nov 3, 2023
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
@iwsimon iwsimon changed the title Fixed canUseEip1014AliasesForXfers Fixed canUseEip1014AliasesForXfers and updateMaxAutoAssociationsWorks Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

Node: Unit Test Results

    2 272 files      2 272 suites   1h 26m 23s ⏱️
118 348 tests 118 314 ✔️ 34 💤 0
126 609 runs  126 575 ✔️ 34 💤 0

Results for commit 5606c29.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 3, 2023

Node: E2E Test Results

    1 files      1 suites   22m 20s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 5606c29.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 3, 2023

Node: Integration Test Results

280 tests   280 ✔️  32m 52s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 5606c29.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 3, 2023

Node: HAPI Test Results

1 242 tests   816 ✔️  1h 14m 16s ⏱️
   165 suites  426 💤
   165 files        0

Results for commit 5606c29.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwsimon iwsimon merged commit 894e75d into develop Nov 6, 2023
10 of 11 checks passed
@iwsimon iwsimon deleted the 9659-CryptoTransferSuite branch November 6, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CryptoTransferSuite CryptoUpdateSuite
3 participants