Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed canUseEip1014AliasesForXfers and updateMaxAutoAssociationsWorks #9667

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Fixed canUseEip1014AliasesForXfers and updateMaxAutoAssociationsWorks #9667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
475b7bd
Enabled HapiTest canUseEip1014AliasesForXfers.
iwsimon Nov 3, 2023
ef530f6
Enabled HapiTest updateMaxAutoAssociationsWorks.
iwsimon Nov 3, 2023
b7b66e8
Merge branch 'develop' into 9659-CryptoTransferSuite
iwsimon Nov 3, 2023
063a56d
Merge branch 'develop' into 9659-CryptoTransferSuite
iwsimon Nov 3, 2023
d048535
Merge branch 'develop' into 9659-CryptoTransferSuite
iwsimon Nov 6, 2023
5606c29
Merge branch 'develop' into 9659-CryptoTransferSuite
iwsimon Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/CryptoTransferSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ private HapiSpec canUseMirrorAliasesForNonContractXfers() {
}

@SuppressWarnings("java:S5669")
// @HapiTest This test is failing due to child records not being correct. Will be enabled once fixed.
@HapiTest
private HapiSpec canUseEip1014AliasesForXfers() {
final var partyCreation2 = "partyCreation2";
final var counterCreation2 = "counterCreation2";
Expand Down
3 changes: 1 addition & 2 deletions ...e/test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/CryptoUpdateSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,8 +395,7 @@ private HapiSpec updateWithEmptyKeyFails() {
.then(cryptoUpdate(TEST_ACCOUNT).key(UPD_KEY).hasPrecheck(INVALID_ADMIN_KEY));
}

// @HapiTest Wrong status! Expected EXISTING_AUTOMATIC_ASSOCIATIONS_EXCEED_GIVEN_LIMIT, was
// INVALID_TRANSACTION_BODY! recheck after ContractUpdateHandler.handle() implemented
@HapiTest
private HapiSpec updateMaxAutoAssociationsWorks() {
final int maxAllowedAssociations = 5000;
final int originalMax = 2;
Expand Down
Loading