Adjust the key gathering context methods to translate exceptions from preHandle #9841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node: E2E Test Results 1 files ± 0 1 suites ±0 21m 5s ⏱️ + 21m 5s Results for commit 0227c86. ± Comparison against base commit 649ea48. This pull request removes 1 and adds 312 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jsync-swirlds
force-pushed
the
09838-fix-key-gathering
branch
from
b320165
to
6193a0b
Compare
jsync-swirlds
force-pushed
the
09838-fix-key-gathering
branch
3 times, most recently
from
ba76ac4
to
f524433
Compare
…preHandle, as key gathering should not fail for non-pure checks. * Modified PreHandleContextImpl to suppress exceptions from PreHandle in `allKeysForTransaction' * Modified HandleContextImpl to suppress exceptions from PreHandle in `allKeysForTransaction' * Modified tests to match Note: These changes assume that services preHandle methods set required keys as early as possible, before making any state-based validations. To be fully correct we will need to modify a few service handlers that do not meet that expectation. Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
jsync-swirlds
force-pushed
the
09838-fix-key-gathering
branch
from
f524433
to
0227c86
Compare
jsync-swirlds
changed the title
rbair23
approved these changes
Nov 16, 2023
kimbor
approved these changes
Nov 16, 2023
nickpoorman
pushed a commit
that referenced
this pull request
Nov 22, 2023
… preHandle (#9841) Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the key gathering context methods to translate exceptions from preHandle; key gathering should not fail for non-pure checks.
allKeysForTransactionallKeysForTransactionNote: These changes assume that services preHandle methods only fail for situations where keys cannot be gathered. To be fully correct we will need to modify a few service handlers that do not meet that expectation.