Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the key gathering context methods to translate exceptions from preHandle #9841

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Adjust the key gathering context methods to translate exceptions from preHandle #9841

merged 1 commit into from
Nov 16, 2023

Commits on Nov 15, 2023

  1. Adjust the key gathering context methods to suppress exceptions from … 

    …preHandle, as key gathering should not fail for non-pure checks.

* Modified PreHandleContextImpl to suppress exceptions from PreHandle in `allKeysForTransaction'
* Modified HandleContextImpl to suppress exceptions from PreHandle in `allKeysForTransaction'
* Modified tests to match

Note: These changes assume that services preHandle methods set required keys as early as possible, before making any state-based validations.  To be fully correct we will need to modify a few service handlers that do not meet that expectation.

Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
    @jsync-swirlds
    jsync-swirlds committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    0227c86 View commit details
    Browse the repository at this point in the history