TokenAndTypeCheckFix (#9672) #9844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
ilko-iliev-lime
requested review from
tinker-michaelj and
a team
as code owners
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Purpose of the PR is fixing the TokenAndTypeCheckSuite. Problems with the checkTokenAndTypeNegativeCases were the following:
In case of a call with invalid token ID to the IsTokenCall class, the status of the result was INVALID_TOKEN_ID, which doesn't match the mono output (success in all cases and false on the isToken field).
In case of a call with invalid token ID to the TokenTypeCall class, the status of the result was REVERTED_SUCCESS, which is a status which overrides the correct one after it is returned, so I had to override the execute function.
Related issue(s):
Fixes #9427
Notes for reviewer:
Checklist