Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ContractUpdateSuite and address ContractUpdateHandle comments #9847

Merged
merged 14 commits into from
Nov 14, 2023
Merged

Fix ContractUpdateSuite and address ContractUpdateHandle comments #9847

merged 14 commits into from
Nov 14, 2023

Commits on Nov 8, 2023

  1. feat: add staking elections validation 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c118442 View commit details
    Browse the repository at this point in the history

  2. fix: calling the update staking election validation instead of the cr… 

    …eate one

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8b553b4 View commit details
    Browse the repository at this point in the history

  3. feature: add auto associations validation 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5ad7a79 View commit details
    Browse the repository at this point in the history

  4. feature: update onlyAffectsExpiry check 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    60160e6 View commit details
    Browse the repository at this point in the history

  5. feature: add new validation and enable a test 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    d754d90 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. fix: incorrect validation 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    2fa659b View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. test: initial unit tests 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    32e4048 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. refactor: move validations from update to validateSemantics 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    ff73aba View commit details
    Browse the repository at this point in the history

  2. refactor: reorder methods 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    0445e52 View commit details
    Browse the repository at this point in the history

  3. refactor: reuse variable 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    d7492e0 View commit details
    Browse the repository at this point in the history

  4. test: finish unit tests 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    363c232 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into 09654_08996-fix-ContractUpdateSuite-and-a… 

    …ddress-comments

# Conflicts:
#	hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/handlers/ContractUpdateHandler.java
    @vtronkov
    vtronkov committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    d84318a View commit details
    Browse the repository at this point in the history

  6. test: fix compile error 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    27eedc2 View commit details
    Browse the repository at this point in the history

  7. test: enable passing test 

    Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
    @vtronkov
    vtronkov committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    ed4d17b View commit details
    Browse the repository at this point in the history