-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9427: Revert after INVALID_ACCOUNT_ID static call #9931
#9427: Revert after INVALID_ACCOUNT_ID static call #9931
Conversation
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
Node: E2E Test Results 1 files ± 0 1 suites ±0 21m 18s ⏱️ + 21m 18s Results for commit 3a6f5d5. ± Comparison against base commit 791ab23. This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Description:
The PR handles a missed case. When we make a static GetAllowance call and the accountId is invalid, then the transaction must be reverted.
See snapshot here.
Related issue(s):
Fixes #9427
Notes for reviewer:
Checklist