Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9427: Revert after INVALID_ACCOUNT_ID static call #9931

Merged
merged 7 commits into from
Nov 20, 2023

Conversation

ilko-iliev-lime
Copy link
Contributor

Description:
The PR handles a missed case. When we make a static GetAllowance call and the accountId is invalid, then the transaction must be reverted.

See snapshot here.

Related issue(s):

Fixes #9427

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
@ilko-iliev-lime ilko-iliev-lime changed the title Applied spotless (#9672) #9427: Add revert after INVALID_ACCOUNT_ID static call Nov 16, 2023
@ilko-iliev-lime ilko-iliev-lime changed the title #9427: Add revert after INVALID_ACCOUNT_ID static call #9427: Revert after INVALID_ACCOUNT_ID static call Nov 16, 2023
Copy link

github-actions bot commented Nov 16, 2023

Node: Unit Test Results

    2 282 files  ±0      2 282 suites  ±0   1h 9m 15s ⏱️ + 1m 38s
118 360 tests +1  118 326 ✔️ +1  34 💤 ±0  0 ±0 
126 678 runs  +1  126 644 ✔️ +1  34 💤 ±0  0 ±0 

Results for commit 3a6f5d5. ± Comparison against base commit 791ab23.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 16, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 18s ⏱️ + 21m 18s
310 tests +309  310 ✔️ +310  0 💤 ±0  0  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0  - 1 

Results for commit 3a6f5d5. ± Comparison against base commit 791ab23.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 16, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 18s ⏱️ -9s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 3a6f5d5. ± Comparison against base commit 791ab23.

♻️ This comment has been updated with latest results.

Copy link

Node: HAPI Test Results

1 246 tests   890 ✔️  1h 27m 38s ⏱️
   166 suites  356 💤
   166 files        0

Results for commit 3ebc08a.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilko-iliev-lime ilko-iliev-lime merged commit 6582f75 into develop Nov 20, 2023
12 of 14 checks passed
@ilko-iliev-lime ilko-iliev-lime deleted the 09427-GetAllowance-call-fix-static-call-case branch November 20, 2023 09:22
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: ilko-iliev-lime <ilko.iliev@limechain.tech>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unconditional, enriched records of read-only HTS system contract calls.
2 participants