Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Datadog tracing #354

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Enable Datadog tracing #354

merged 3 commits into from
Oct 3, 2023

Conversation

jfreda
Copy link
Contributor

@jfreda jfreda commented Sep 29, 2023

New config block:

datadog {
  enabled = true
  env     = "staging"
  service = "hermes"
}

@jfreda jfreda added the enhancement New feature or request label Sep 29, 2023
@jfreda jfreda requested a review from a team as a code owner September 29, 2023 22:45
@jfreda jfreda merged commit 31d301a into main Oct 3, 2023
2 checks passed
@jfreda jfreda deleted the jfreda/add-datadog-2 branch October 3, 2023 17:39
jeffdaley added a commit that referenced this pull request Oct 4, 2023
@jeffdaley
Squashed commit of the following:
de53cc9 
commit 6cf47b1
Author: Jeff Daley <jeffdaley@users.noreply.github.com>
Date:   Tue Oct 3 16:31:01 2023 -0400

    Revert HermesUser changes

commit 31d301a
Author: Josh Freda <jfreda@users.noreply.github.com>
Date:   Tue Oct 3 12:39:28 2023 -0500

    Enable Datadog tracing (#354)

    * Add Datadog configuration

    * Add datadog package

    * Enable Datadog tracing

commit 0d61dc3
Author: Jeff Daley <jeffdaley@users.noreply.github.com>
Date:   Mon Oct 2 13:58:57 2023 -0400

    EmptyStateText (#355)

    * Refactor EmptyStateText

    * Tweak API

    * Convert to .gts
jeffdaley added a commit that referenced this pull request Oct 4, 2023
@jeffdaley
Squashed commit of the following:
18bce76 
commit cfc61f8
Author: Jeff Daley <jeffdaley@users.noreply.github.com>
Date:   Tue Oct 3 20:28:07 2023 -0400

    Remove `imageIsLoading`

commit 6cf47b1
Author: Jeff Daley <jeffdaley@users.noreply.github.com>
Date:   Tue Oct 3 16:31:01 2023 -0400

    Revert HermesUser changes

commit 31d301a
Author: Josh Freda <jfreda@users.noreply.github.com>
Date:   Tue Oct 3 12:39:28 2023 -0500

    Enable Datadog tracing (#354)

    * Add Datadog configuration

    * Add datadog package

    * Enable Datadog tracing

commit 0d61dc3
Author: Jeff Daley <jeffdaley@users.noreply.github.com>
Date:   Mon Oct 2 13:58:57 2023 -0400

    EmptyStateText (#355)

    * Refactor EmptyStateText

    * Tweak API

    * Convert to .gts
jeffdaley added a commit that referenced this pull request Oct 6, 2023
@jeffdaley
EditableFields enhancements and bugfixes (#340)
b4a3f5f 
* Define SessionService exports

* WIP convert document route to TS

* Update modifiedTime

* Remove thumbnail, update Tile modifiedAgo

* Cleanup

* Fix modifiedTime type

* Update `modifiedAgo` and `timeAgo`

* Add tests

* Rework "modifiedTime" calculations

* Fix sidebar timeAgo; add documentation

* Add "Modified" to tile

* Remove console.logs

* Update document.ts

* Fix incorrect types and test

* Autofocus PeopleSelects in the sidebar

* Remove console.log

* Improve loading states

* Update/add tests

* Remove console.logs

* Change some sidebar empty states

* Update EditableField components

* Fixed tests

* Add dismissible test

* Remove default margin from H1

* Add RelatedResource emptyState button

* Animation polish

* EditableContainer, remove some TODOs

* Tweak save-state styles

* Add created types

* Clarify types

* Remove comment

* Remove console logs

* Remove unused import

* Move loading to Person component

* Change loading affordance

* Create a `HermesUser` component

* Add tests

* Move test from acceptance to integration

* Remove kickOff task

* Grammar tweak

* Move getDocType into route

* Interface tweak

* Convert `test` to `todo`

* Update related-resources-test.ts

* Update related-resources-test.ts

* Add documentation

* Add `rr.showModal` tests

* Refactor EmptyStateText

* Tweak API

* WIP test

* Update CSS

* Convert to .gts

* Remove shared classes

* Fix bug on Approvers/Contributors

* Add missing import

* `onChange` → `onCommit`

* Save commit

* Mostly working ?

clicking chevkbox on PEOPLE doesnt work...

* Squashed commit of the following:

commit 6cf47b1
Author: Jeff Daley <jeffdaley@users.noreply.github.com>
Date:   Tue Oct 3 16:31:01 2023 -0400

    Revert HermesUser changes

commit 31d301a
Author: Josh Freda <jfreda@users.noreply.github.com>
Date:   Tue Oct 3 12:39:28 2023 -0500

    Enable Datadog tracing (#354)

    * Add Datadog configuration

    * Add datadog package

    * Enable Datadog tracing

commit 0d61dc3
Author: Jeff Daley <jeffdaley@users.noreply.github.com>
Date:   Mon Oct 2 13:58:57 2023 -0400

    EmptyStateText (#355)

    * Refactor EmptyStateText

    * Tweak API

    * Convert to .gts

* Squashed commit of the following:

commit cfc61f8
Author: Jeff Daley <jeffdaley@users.noreply.github.com>
Date:   Tue Oct 3 20:28:07 2023 -0400

    Remove `imageIsLoading`

commit 6cf47b1
Author: Jeff Daley <jeffdaley@users.noreply.github.com>
Date:   Tue Oct 3 16:31:01 2023 -0400

    Revert HermesUser changes

commit 31d301a
Author: Josh Freda <jfreda@users.noreply.github.com>
Date:   Tue Oct 3 12:39:28 2023 -0500

    Enable Datadog tracing (#354)

    * Add Datadog configuration

    * Add datadog package

    * Enable Datadog tracing

commit 0d61dc3
Author: Jeff Daley <jeffdaley@users.noreply.github.com>
Date:   Mon Oct 2 13:58:57 2023 -0400

    EmptyStateText (#355)

    * Refactor EmptyStateText

    * Tweak API

    * Convert to .gts

* Improved component sharing

* Add `@type="people"`

* Remove console.logs

* Add support for approvers

* CustomEditableFields cleanup and documentation

* Rename some functions

* Clean up EditableField template

* Add EditableField::ReadValue component

* More cleanup and reorganization

* More documentation

* Improve `isSaving` styles

* Fix customEditable People Field saving

* Improve types

* Stub some tests

* Refactor the `type` argument; EF test

* Update editable-field-test.ts

* EF tests

* More tests

* More tests

* Fix test, remove `click-outside`

* Tweak argument name

* Update yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubhavmishra anubhavmishra anubhavmishra approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfreda @anubhavmishra