EmptyStateText #355
Merged
EmptyStateText #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreda
approved these changes
Oct 2, 2023
jeffdaley
added a commit
that referenced
this pull request
Oct 4, 2023
commit 6cf47b1 Author: Jeff Daley <jeffdaley@users.noreply.github.com> Date: Tue Oct 3 16:31:01 2023 -0400 Revert HermesUser changes commit 31d301a Author: Josh Freda <jfreda@users.noreply.github.com> Date: Tue Oct 3 12:39:28 2023 -0500 Enable Datadog tracing (#354) * Add Datadog configuration * Add datadog package * Enable Datadog tracing commit 0d61dc3 Author: Jeff Daley <jeffdaley@users.noreply.github.com> Date: Mon Oct 2 13:58:57 2023 -0400 EmptyStateText (#355) * Refactor EmptyStateText * Tweak API * Convert to .gts
jeffdaley
added a commit
that referenced
this pull request
Oct 4, 2023
commit cfc61f8 Author: Jeff Daley <jeffdaley@users.noreply.github.com> Date: Tue Oct 3 20:28:07 2023 -0400 Remove `imageIsLoading` commit 6cf47b1 Author: Jeff Daley <jeffdaley@users.noreply.github.com> Date: Tue Oct 3 16:31:01 2023 -0400 Revert HermesUser changes commit 31d301a Author: Josh Freda <jfreda@users.noreply.github.com> Date: Tue Oct 3 12:39:28 2023 -0500 Enable Datadog tracing (#354) * Add Datadog configuration * Add datadog package * Enable Datadog tracing commit 0d61dc3 Author: Jeff Daley <jeffdaley@users.noreply.github.com> Date: Mon Oct 2 13:58:57 2023 -0400 EmptyStateText (#355) * Refactor EmptyStateText * Tweak API * Convert to .gts
jeffdaley
added a commit
that referenced
this pull request
Oct 6, 2023
* Define SessionService exports * WIP convert document route to TS * Update modifiedTime * Remove thumbnail, update Tile modifiedAgo * Cleanup * Fix modifiedTime type * Update `modifiedAgo` and `timeAgo` * Add tests * Rework "modifiedTime" calculations * Fix sidebar timeAgo; add documentation * Add "Modified" to tile * Remove console.logs * Update document.ts * Fix incorrect types and test * Autofocus PeopleSelects in the sidebar * Remove console.log * Improve loading states * Update/add tests * Remove console.logs * Change some sidebar empty states * Update EditableField components * Fixed tests * Add dismissible test * Remove default margin from H1 * Add RelatedResource emptyState button * Animation polish * EditableContainer, remove some TODOs * Tweak save-state styles * Add created types * Clarify types * Remove comment * Remove console logs * Remove unused import * Move loading to Person component * Change loading affordance * Create a `HermesUser` component * Add tests * Move test from acceptance to integration * Remove kickOff task * Grammar tweak * Move getDocType into route * Interface tweak * Convert `test` to `todo` * Update related-resources-test.ts * Update related-resources-test.ts * Add documentation * Add `rr.showModal` tests * Refactor EmptyStateText * Tweak API * WIP test * Update CSS * Convert to .gts * Remove shared classes * Fix bug on Approvers/Contributors * Add missing import * `onChange` → `onCommit` * Save commit * Mostly working ? clicking chevkbox on PEOPLE doesnt work... * Squashed commit of the following: commit 6cf47b1 Author: Jeff Daley <jeffdaley@users.noreply.github.com> Date: Tue Oct 3 16:31:01 2023 -0400 Revert HermesUser changes commit 31d301a Author: Josh Freda <jfreda@users.noreply.github.com> Date: Tue Oct 3 12:39:28 2023 -0500 Enable Datadog tracing (#354) * Add Datadog configuration * Add datadog package * Enable Datadog tracing commit 0d61dc3 Author: Jeff Daley <jeffdaley@users.noreply.github.com> Date: Mon Oct 2 13:58:57 2023 -0400 EmptyStateText (#355) * Refactor EmptyStateText * Tweak API * Convert to .gts * Squashed commit of the following: commit cfc61f8 Author: Jeff Daley <jeffdaley@users.noreply.github.com> Date: Tue Oct 3 20:28:07 2023 -0400 Remove `imageIsLoading` commit 6cf47b1 Author: Jeff Daley <jeffdaley@users.noreply.github.com> Date: Tue Oct 3 16:31:01 2023 -0400 Revert HermesUser changes commit 31d301a Author: Josh Freda <jfreda@users.noreply.github.com> Date: Tue Oct 3 12:39:28 2023 -0500 Enable Datadog tracing (#354) * Add Datadog configuration * Add datadog package * Enable Datadog tracing commit 0d61dc3 Author: Jeff Daley <jeffdaley@users.noreply.github.com> Date: Mon Oct 2 13:58:57 2023 -0400 EmptyStateText (#355) * Refactor EmptyStateText * Tweak API * Convert to .gts * Improved component sharing * Add `@type="people"` * Remove console.logs * Add support for approvers * CustomEditableFields cleanup and documentation * Rename some functions * Clean up EditableField template * Add EditableField::ReadValue component * More cleanup and reorganization * More documentation * Improve `isSaving` styles * Fix customEditable People Field saving * Improve types * Stub some tests * Refactor the `type` argument; EF test * Update editable-field-test.ts * EF tests * More tests * More tests * Fix test, remove `click-outside` * Tweak argument name * Update yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
EmptyStatecomponent:CustomEditableField::EmptyState→EmptyStateText---→Nonevalueargument to override the default, e.g.,<EmptyStateText @value="Empty, sorry." />Also switches the Approvers and Contributors sections to use this component.