This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Add lifecycle sidecar to mesh gateway #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
added
area/multi-dc
lkysow
force-pushed
the
mesh-gateway-lifecycle-sidecar
branch
2 times, most recently
from
e6aefe4
to
6b10e24
Compare
|
For testing:
|
lkysow
commented
Mar 18, 2020
ishustava
reviewed
Mar 20, 2020
lkysow
force-pushed
the
mesh-gateway-lifecycle-sidecar
branch
from
74c1880
to
f46a444
Compare
ishustava
approved these changes
Mar 20, 2020
When Consul clients in Kubernetes restart, they lose their registrations. This causes any mesh gateways to be deregistered. To solve this, we need to run a sidecar that ensures the service is always registered: a lifecycle-sidecar. For the lifecycle-sidecar to work, it needs a service.hcl service config file. This required adding an init container that writes this file and does the initial service registration. Since the init container is registering the service, the consul connect envoy -mesh-gateway command no longer needs the -register flag.
lkysow
force-pushed
the
mesh-gateway-lifecycle-sidecar
branch
from
f46a444
to
0474f5d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Consul clients in Kubernetes restart, they lose their
registrations. This causes any mesh gateways to be deregistered. To
solve this, we need to run a sidecar that ensures the service is always
registered: a lifecycle-sidecar.
For the lifecycle-sidecar to work, it needs a service.hcl service config
file. This required adding an init container that writes this file and
does the initial service registration. Since the init container is
registering the service, the consul connect envoy -mesh-gateway command
no longer needs the -register flag.