Add -token-sink-file flag to acl-init #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
acl-init-token-write
branch
from
99205be
to
fe59489
Compare
lkysow
force-pushed
the
acl-init-token-write
branch
from
fe59489
to
68d51f8
Compare
lkysow
force-pushed
the
acl-init-token-write
branch
from
68d51f8
to
05b6bb9
Compare
lkysow
force-pushed
the
wan-federation-base
branch
from
7a5b597
to
9cdda6c
Compare
ishustava
approved these changes
Mar 19, 2020
If this flag is set then we will write the acl token to that file. Also remove -init-type=sync. If -init-type was set to sync the behaviour didn't change so remove that from the docs.
lkysow
force-pushed
the
acl-init-token-write
branch
from
290277e
to
1549230
Compare
lkysow
added a commit
to hashicorp/consul-helm
that referenced
this pull request
Mar 23, 2020
As part of hashicorp/consul-k8s#232 we removed the docs about -init-type=sync. If -init-type was set to sync it actually had no effect. Only -init-type=client had effect so this change stops setting that flag in the case of sync.
lkysow
added a commit
to hashicorp/consul-helm
that referenced
this pull request
Mar 30, 2020
As part of hashicorp/consul-k8s#232 we removed the docs about -init-type=sync. If -init-type was set to sync it actually had no effect. Only -init-type=client had effect so this change stops setting that flag in the case of sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flag
-token-sink-filetoacl-initcommand. Ifinit-type=sync(which is used for everything except consul agents) then if-token-sink-fileis set, we will write the token to that file.This is needed for the mesh-gateway lifecycle sidecar (hashicorp/consul-helm#380)