This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Remove use of -init-type=sync as it has no effect #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
mesh-gateway-use-loadbalancer-address
branch
from
76e78be
to
a69bee4
Compare
As part of hashicorp/consul-k8s#232 we removed the docs about -init-type=sync. If -init-type was set to sync it actually had no effect. Only -init-type=client had effect so this change stops setting that flag in the case of sync.
lkysow
force-pushed
the
remove-init-type-sync
branch
from
fda58cb
to
ce92d48
Compare
lkysow
changed the base branch from
mesh-gateway-use-loadbalancer-address
to
wan-federation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of hashicorp/consul-k8s#232 we removed
the docs about -init-type=sync. This does not break anything because if -init-type was set to sync it actually had no effect. Only -init-type=client had effect.