Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go 1.21.7 #20545

Merged
merged 2 commits into from
Feb 8, 2024
Merged

use go 1.21.7 #20545

merged 2 commits into from
Feb 8, 2024

Conversation

skpratt
Copy link
Collaborator

@skpratt skpratt commented Feb 8, 2024

This bumps golang to avoid any change in the BoringCrypto module for FIPS builds: golang/go#65321

@skpratt skpratt added backport/1.18 pr/no-changelog PR does not need a corresponding .changelog entry labels Feb 8, 2024
@skpratt skpratt marked this pull request as ready for review February 8, 2024 20:31
@skpratt skpratt requested a review from zalimeni February 8, 2024 22:42
@skpratt skpratt changed the title 1.21.7 use go 1.21.7 Feb 8, 2024
@skpratt skpratt enabled auto-merge (squash) February 8, 2024 22:56
@zalimeni
Copy link
Member

zalimeni commented Feb 8, 2024

@skpratt we typically add a changelog entry for these - copying from https://github.com/hashicorp/consul/pull/20062/files#diff-b0b11f4216bda65c2a8dbc878d1e646c7e0355af558118dee097199909b4afd6 you could use:

```release-note:improvement
Upgrade to use Go 1.21.7.
```

@zalimeni
Copy link
Member

zalimeni commented Feb 8, 2024

We should also backport this to n-2 and LTS (1.15) for consistency

@skpratt skpratt disabled auto-merge February 8, 2024 22:57
@skpratt skpratt added backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Feb 8, 2024
@zalimeni zalimeni added the backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. label Feb 8, 2024
@skpratt skpratt removed pr/no-changelog PR does not need a corresponding .changelog entry backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. labels Feb 8, 2024
@zalimeni zalimeni added the backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. label Feb 8, 2024
@hc-github-team-consul-core
Copy link
Collaborator

@skpratt, a backport is missing for this PR [20545] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

2 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

@skpratt, a backport is missing for this PR [20545] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@skpratt, a backport is missing for this PR [20545] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants