Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take up too many tcp connections when watching on a huge number of services #2596

Closed
hehailong5 opened this issue Dec 14, 2016 · 3 comments
Closed
Labels
theme/api Relating to the HTTP API interface type/enhancement Proposed improvement or new feature

Comments

@hehailong5
Copy link

hehailong5 commented Dec 14, 2016

I know we can watch on /v1/catalog/services to get notified if there is any changes on any service, and what's more, only one tcp connection is needed.
as the document states, the watch would return the full service list other than the changed ones. it is a huge overhead to find the changed ones and what's have changed at client side, since we have a large service set. we have to watch on /v1/catalog/service/{service name} for each service, but here comes another problem: each watch would take up a persistent tcp connection, the connection resource would soon run out. so, what's the best practice to watch the changes on a larger set of services?

@slackpad slackpad added the type/enhancement Proposed improvement or new feature label Dec 20, 2016
@slackpad slackpad added this to the 0.7.4 milestone Dec 20, 2016
@slackpad
Copy link
Contributor

Hi @hehailong5 I think we could possibly add a new argument to these APIs to do some filtering on the server. Will take a look.

@slackpad slackpad removed this from the Triaged milestone Apr 18, 2017
@slackpad
Copy link
Contributor

slackpad commented May 2, 2017

This is similar to #2791, but applied to catalog.

@slackpad slackpad added the theme/api Relating to the HTTP API interface label May 25, 2017
@slackpad
Copy link
Contributor

Closing this against #3657 which added HTTP/2 support, which works great for this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/api Relating to the HTTP API interface type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants