Update metric names and add a legacy config flag #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
approved these changes
Oct 5, 2017
| <td>hits</td> | ||
| <td>counter</td> | ||
| </tr> | ||
| <tr> |
There was a problem hiding this comment.
These are already down in "cluster health", though they do make sense here. Maybe move that stuff up?
agent/config/runtime_test.go
Outdated
| @@ -1658,8 +1658,8 @@ func TestConfigFlagsAndEdgecases(t *testing.T) { | |||
| `}, | |||
| patch: func(rt *RuntimeConfig) { | |||
| rt.DataDir = dataDir | |||
| rt.TelemetryAllowedPrefixes = []string{"foo"} | |||
| rt.TelemetryBlockedPrefixes = []string{"bar"} | |||
| rt.TelemetryAllowedPrefixes = append([]string{"foo"}, rt.TelemetryAllowedPrefixes...) | |||
There was a problem hiding this comment.
This should have the expected stuff set explicitly. I'd also add another case to TestConfigFlagsAndEdgecases that exercises this new flag directly.
|
The duplicate metrics are not super cheap, so we will likely want to remove the old ones as soon as possible. |
slackpad
reviewed
Oct 5, 2017
| <td>queries</td> | ||
| <td>counter</td> | ||
| </tr> | ||
| <tr> | ||
| <td>`consul.http.<verb>.<path>`</td> |
There was a problem hiding this comment.
This should move up to the agent section, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the double
consul.consul.prefix on the metric names, adds undocumented metrics to the telemetry docs, and adds anenable_deprecated_namesfield to the telemetry config.