Add "only_passing" option to DNS config #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This excludes nodes from DNS results if their healthchecks are in any non-passing state, not just if they're critical.
|
Looks good! @ebroder could you add a test for this behavior? |
|
Thanks for the look - just pushed a test case. |
|
LGTM! Thanks! |
armon
added a commit
that referenced
this pull request
Jan 13, 2015
Add "only_passing" option to DNS config
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
* Change import paths in tests to reference merged repo * Fix the import in go mod and sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This excludes nodes from DNS results if their healthchecks are in any non-passing state state, not just if they're critical.
In our environment, we only want to send traffic to nodes that we know are healthy. Our healthchecks often return both warning and unknown to indicate that something is wrong (the former to indicate that the node is online but we don't want to send traffic to it, e.g. for draining the node; and the latter for ¯_(ツ)_/¯)