Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Service Mesh - Topology tab and basic layout #8788

Merged
merged 23 commits into from
Oct 5, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Sep 30, 2020

This is the foundational layout of the Topology Tab with Service Mesh visualization.

🎉 Highlights

  • TopologyMetrics component holds all the logic for making DOM calculations and dynamically drawing the SVG elements in the Topology tab.
  • Integration of new endpoint /v1/internal/ui/service-topology/
  • Helper that returns health checks in a percentage format
  • Styling files live in component folder

🐛 Present bugs
To be fixed before merge. Ran into an ember issue when covering the use case, Topology Tab should not be displayed if Connect is not enabled.

To-do

topology

@kaxcode kaxcode added the theme/ui Anything related to the UI label Sep 30, 2020
@kaxcode kaxcode requested a review from a team September 30, 2020 21:45
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking amazing! 👏 I left mainly a few non-important suggestions, and I know this is going to be iterated on. I think the most important thing is making sure the viz redraws when a blocking query comes in.

I'm gonna approve this as it looks great and is useful for users as is, and I know you'll be building on this moving forwards. Might be worthwhile just fixing up that blocking query support, either on the end of here, or the next iterative PR you do on this.

Actually, that grafana link is the other thing that isn't functional as is - maybe we should catch up on that and get that in here (or straight after) also?

ui-v2/app/components/topology-metrics/index.js Outdated Show resolved Hide resolved
ui-v2/app/components/topology-metrics/index.js Outdated Show resolved Hide resolved
ui-v2/app/components/topology-metrics/index.hbs Outdated Show resolved Hide resolved
ui-v2/app/components/topology-metrics/index.hbs Outdated Show resolved Hide resolved
ui-v2/app/components/topology-metrics/index.js Outdated Show resolved Hide resolved
ui-v2/app/routes/dc/services/show/topology.js Show resolved Hide resolved
@kaxcode kaxcode force-pushed the ui/feature/service-mesh-topology-tab branch from ab26552 to 3be2ac4 Compare October 1, 2020 19:19
@kaxcode
Copy link
Contributor Author

kaxcode commented Oct 1, 2020

@johncowen I have the @metricsHref changes locally. I'll push them after we get #8798 merged.

@kaxcode kaxcode force-pushed the ui/feature/service-mesh-topology-tab branch 2 times, most recently from 4eeff6f to 72253f8 Compare October 5, 2020 16:34
@kaxcode kaxcode force-pushed the ui/feature/service-mesh-topology-tab branch from 72253f8 to 1002e1b Compare October 5, 2020 16:34
@kaxcode kaxcode requested a review from johncowen October 5, 2020 16:45
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kaxcode kaxcode merged commit f26201a into master Oct 5, 2020
@kaxcode kaxcode deleted the ui/feature/service-mesh-topology-tab branch October 5, 2020 17:07
@kaxcode kaxcode added this to the 1.9 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants