-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Service Mesh - Topology tab and basic layout #8788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking amazing! 👏 I left mainly a few non-important suggestions, and I know this is going to be iterated on. I think the most important thing is making sure the viz redraws when a blocking query comes in.
I'm gonna approve this as it looks great and is useful for users as is, and I know you'll be building on this moving forwards. Might be worthwhile just fixing up that blocking query support, either on the end of here, or the next iterative PR you do on this.
Actually, that grafana link is the other thing that isn't functional as is - maybe we should catch up on that and get that in here (or straight after) also?
ab26552
to
3be2ac4
Compare
@johncowen I have the |
23ba694
to
ca6d9a4
Compare
ca6d9a4
to
a6aa865
Compare
4eeff6f
to
72253f8
Compare
72253f8
to
1002e1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the foundational layout of the Topology Tab with Service Mesh visualization.
🎉 Highlights
/v1/internal/ui/service-topology/
🐛 Present bugs
✅
To be fixed before merge. Ran into an ember issue when covering the use case, Topology Tab should not be displayed if Connect is not enabled.To-do