Consul prefix services ACLs #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maver1ck Is this something that you guys need? To me prefix-based on service name seems a bit odd. I think exact match is simpler to reason about, but I'd appreciate the feedback |
|
Hi, I explain why.
Then I'd like to:
It'll be rather microservices architecture so I will have A LOT of services and making ACL for every will be labor-intensive and difficult to maintain. I hope I made it clear. Maybe we could do this as an option in config file. |
|
@maver1ck This makes sense to me! |
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
Support transparent proxy in the consul helm chart * Add new connectInject.transparentProxy.defaultEnabled value (default to true) that will allow users to enable or disable tproxy for each helm installation. * Add acceptance tests for connect-inject to test with tproxy * Acceptance tests default to tproxy not enabled since we don't fully support it for all features yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm changed the way of consul checking service ACLs.
It's prefix based in this commit. No exact match like before.
What do you think about merging this to repo ?