Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid panics with marked Index key values #451

Merged
merged 1 commit into from
Mar 1, 2021
Merged

avoid panics with marked Index key values #451

merged 1 commit into from
Mar 1, 2021

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Feb 26, 2021

Index keys must be unmarked to convert them to a primitive type.

Add tests for overall Index test coverage.

@jbardin jbardin requested a review from a team February 26, 2021 22:34
@jbardin jbardin changed the title avoid panics with marked index key values avoid panics with marked Index key values Feb 26, 2021
alisdair
alisdair approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for documenting so many edge cases with tests.

@jbardin jbardin merged commit d7e7bca into main Mar 1, 2021
@jbardin jbardin deleted the jbardin/marked-index branch March 1, 2021 14:14
@jbardin jbardin mentioned this pull request Mar 2, 2021
Closed
This was referenced Mar 11, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisdair alisdair alisdair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbardin @alisdair