Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass components directly to compiled MDX function #330

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

timneutkens
Copy link
Contributor

@timneutkens timneutkens commented Jan 9, 2023

This will make it easier to add support for React Server Components in a follow-up PR.

MDX already takes a components prop so the additional context provider is not needed.

This will make it easier to add support for React Server Components in a follow-up PR.
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 9, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks @timneutkens 🙏

@BRKalow BRKalow merged commit 52b2869 into hashicorp:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants