Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort-by fields for paginated List RPCs #11742

Closed
tgross opened this issue Dec 23, 2021 · 1 comment · Fixed by #12186
Closed

sort-by fields for paginated List RPCs #11742

tgross opened this issue Dec 23, 2021 · 1 comment · Fixed by #12186
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/api HTTP API and SDK issues type/enhancement
Milestone

Comments

@tgross
Copy link
Member

tgross commented Dec 23, 2021

The paginator introduced in #11648 allows API calls to get smaller subsets of the data. But without the ability to sort the API by a particular field, these values are always returned in the order of ID (the same as they are found in the state store). For APIs like Deployment.List and Eval.List, this isn't the most useful ordering. The command line or UI can sort unpaged responses by arbitrary fields of course, but for paged responses this behavior is less desirable.

cc @ChaiWithJai as a heads up

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/api HTTP API and SDK issues type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants