Pass a combination of ip and port to the task environment. #704
Conversation
The different labels can be on different IPs.
| @@ -347,9 +347,8 @@ func (d *DockerDriver) createContainer(ctx *ExecContext, task *structs.Task, dri | |||
| // TODO refactor the implementation in GetTaskEnv to match | |||
| // the 0.2 ports world view. Docker seems to be the only place where | |||
| // this is actually needed, but this is kinda hacky. | |||
There was a problem hiding this comment.
Not sure what to do with this comment. What is the 0.2 ports world view? A port map is now passed to the taskEnv so that it can use this when building out the ports env.
There was a problem hiding this comment.
Yeah I think you can delete that. Your PR is the proper handling
|
This PR requires some updates to documentation. @dadgar: do you want to add a general description of this change to the docs? I think replacing NOMAD_PORT_"label" = port with NOMAD_IP_"label" = "ip:port" requires an introduction or general description? |
| // E.g. $NOMAD_PORT_1 or $NOMAD_PORT_http | ||
| PortPrefix = "NOMAD_PORT_" | ||
| // E.g. $NOMAD_IP_1=127.0.0.1:1 or $NOMAD_IP_http=127.0.0.1:80 | ||
| IPPortPrefix = "NOMAD_IP_" |
There was a problem hiding this comment.
@iverberk Can we name this NOMAD_ADDR? I think addr sounds better since the value would be a ip:port and not just the IP.
|
All comments are addressed. |
|
LGTM. Can we add documentation here: https://github.com/hashicorp/nomad/blob/master/website/source/docs/jobspec/networking.html.md |
|
Sure, I'll update the docs. |
|
👍 |
Pass a combination of ip and port to the task environment.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
The different labels can be on different IPs so pass in a combination of the two.