Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop persisting coordinate state to the snapshot/restore #489

Closed
preetapan opened this issue Oct 20, 2017 · 1 comment
Closed

Stop persisting coordinate state to the snapshot/restore #489

preetapan opened this issue Oct 20, 2017 · 1 comment
Assignees

Comments

@preetapan
Copy link

Follow up on #487 after discussion with @slackpad

We currently persist the coordinate subsystem's state to disk, making it much harder to clean up after errors and incorrect values (like NaN and large adjustment values). This feature was added as an optimization to prevent a restart from causing Serf to take another few cycles before it converges.

Instead, we want to remove this persistence mechanism and reset coordinates to the origin on restart. This prevents operators from having to do complex recovery mechanisms like hand editing the local snapshot file on errors, and it should still converge fast after a few rounds of gossip.

@preetapan preetapan self-assigned this Oct 20, 2017
@preetapan
Copy link
Author

Fixed in #490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant