-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): Map Tokens #1411
feat(lib): Map Tokens #1411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really awesome work 🎉 I got some comments more in the realm of nit-picks, but I think they are easy and worthy to address :)
packages/@cdktf/provider-generator/lib/get/generator/models/attribute-model.ts
Outdated
Show resolved
Hide resolved
packages/@cdktf/provider-generator/lib/get/generator/models/attribute-type-model.ts
Show resolved
Hide resolved
@jsteinich could you rebase this? |
@jsteinich Could you add a change log entry, please? |
I added a short entry. Let me know if that's not what you had in mind. |
Test failure seems unrelated:
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Dividing up #1299, starting with tokens for map (string indexed / Record<string, any>) types as these are quite common.
Some points that came up from the original design:
IResolvable
option for types of mapsAnyMap
computed wrapper for completions sakeIResolvable
to the value type in that casemap<list>
type since current code doesn't distinguish between that andlist<map>
type. It's very rare, so that can be a different project down the road