Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): Map Tokens #1411

Merged
merged 24 commits into from
Jan 17, 2022
Merged

feat(lib): Map Tokens #1411

merged 24 commits into from
Jan 17, 2022

Conversation

jsteinich
Copy link
Collaborator

@jsteinich jsteinich commented Dec 12, 2021

Dividing up #1299, starting with tokens for map (string indexed / Record<string, any>) types as these are quite common.

Some points that came up from the original design:

  • Map value type needs to be exact in order for jsii to work. Added support for all primitive types and left IResolvable option for types of maps
  • Added an AnyMap computed wrapper for completions sake
  • boolean maps support tokens, but since booleans don't, added IResolvable to the value type in that case
  • Didn't fully handle map<list> type since current code doesn't distinguish between that and list<map> type. It's very rare, so that can be a different project down the road
  • Added a fix for the C# edge provider Constructs version error
  • I didn't add to the go edge provider test. I could take a stab at it, but probably for someone with go experience (or we can add later).

Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome work 🎉 I got some comments more in the realm of nit-picks, but I think they are easy and worthy to address :)

test/csharp/edge/test.ts Outdated Show resolved Hide resolved
@DanielMSchmidt
Copy link
Contributor

@jsteinich could you rebase this?

@skorfmann
Copy link
Contributor

@jsteinich Could you add a change log entry, please?

@jsteinich
Copy link
Collaborator Author

@jsteinich Could you add a change log entry, please?

I added a short entry. Let me know if that's not what you had in mind.

@jsteinich
Copy link
Collaborator Author

Test failure seems unrelated:

Command failed: terraform init
    ╷
    │ Error: Failed to install provider
    │ 
    │ Error while installing kreuzwerker/docker v2.14.0: could not query provider
    │ registry for registry.terraform.io/kreuzwerker/docker: failed to retrieve
    │ authentication checksums for provider: 403 Server failed to authenticate
    │ the request. Make sure the value of Authorization header is formed
    │ correctly including the signature.
    ╵

@DanielMSchmidt DanielMSchmidt merged commit d1f2c3e into hashicorp:main Jan 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants