Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider-generator): Add special case in case resource is named 'object' #2138

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Sep 23, 2022

  • fix(provider-generator): Add special case in case resource is named 'object'
  • test(provider-generator): Add test for resources named object or string

Closes #2137 and unblocks CI (e.g. #2127)

@ansgarm ansgarm changed the title allow resources named object fix(provider-generator): Add special case in case resource is named 'object' Sep 23, 2022
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a follow up ticket to adjust convert to handle this case

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated typescript classes can override native js types
2 participants