Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider-generator): Use registry.terraform.io links instead of old terraform.io #2696

Merged
merged 5 commits into from
Mar 8, 2023
Merged

fix(provider-generator): Use registry.terraform.io links instead of old terraform.io #2696

merged 5 commits into from
Mar 8, 2023

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Mar 7, 2023

  • chore(provider-generator): introduce branded types for fully qualified provider name
  • chore(provider-generator): make fqpn available in resource model
  • fix(provider-generator): Use registry.terraform.io links instead of old terraform.io
  • chore(provider-generator): update tests and snapshots

@ansgarm ansgarm requested a review from a team as a code owner March 7, 2023 14:18
@ansgarm ansgarm requested review from mutahhir and Maed223 and removed request for a team March 7, 2023 14:18
@ansgarm ansgarm changed the title fix provider docs links fix(provider-generator): Use registry.terraform.io links instead of old terraform.io Mar 7, 2023
@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

DanielMSchmidt
DanielMSchmidt approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

packages/@cdktf/provider-generator/lib/get/generator/provider-schema.ts Show resolved Hide resolved
@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@ansgarm ansgarm merged commit 03c779e into main Mar 8, 2023
@ansgarm ansgarm deleted the fix-provider-docs-links branch March 8, 2023 08:01
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielMSchmidt DanielMSchmidt DanielMSchmidt approved these changes

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

@Maed223 Maed223 Awaiting requested review from Maed223 Maed223 is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/provider-integration ci/run-unit/@cdktf/hcl2cdk ci/run-unit/@cdktf/provider-generator size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansgarm @team-tf-cdk @DanielMSchmidt