Fix -var handling #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultyng
force-pushed
the
logging
branch
5 times, most recently
from
2e5e74b
to
21c9bef
Compare
Add apply test with -var usage, simplify exec.Cmd assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-varvalues were passed incorrectly as args, this cleans it up and adds testing in anapplytest by roundtripping a variable to an output.I also added a helper to simplify the
exec.Cmdassertions logic (including env var checking, as this will be useful for reattach and some other things). I addedt.Runin places where there were multiple sequential test cases to give cleaner output and scoping but also to allow for testing both runs even if the first fails.This is dependent upon #32