Add terraform workspace commands #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultyng
commented
Aug 19, 2020
| @@ -0,0 +1 @@ | |||
| this file is used to hold this directory in git | |||
There was a problem hiding this comment.
directory presence is used by the Terraform CLI for workspaces
paultyng
changed the title
This comment has been minimized.
This comment has been minimized.
Merged
appilon
reviewed
Aug 29, 2020
| return errors.New(stderr) | ||
| case workspaceDoesNotExistRegexp.MatchString(stderr): | ||
| submatches := workspaceDoesNotExistRegexp.FindStringSubmatch(stderr) | ||
| if len(submatches) == 2 { |
There was a problem hiding this comment.
This feels odd to me but I have no context.
There was a problem hiding this comment.
Yeah I think at some point we will need to overhaul this from a switch to something a bit more sophisticated.
There was a problem hiding this comment.
I could use named groups and make it a bit cleaner possibly, but not without a lot of extra code for this single case.
appilon
reviewed
Aug 29, 2020
appilon
reviewed
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.