Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS App Mesh now supports HTTP2 and gRPC services #10803

Closed
ewbankkit opened this issue Nov 8, 2019 · 8 comments · Fixed by #11669
Closed

AWS App Mesh now supports HTTP2 and gRPC services #10803

ewbankkit opened this issue Nov 8, 2019 · 8 comments · Fixed by #11669
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 8, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS App Mesh now supports HTTP2 and gRPC services.

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_appmesh_route" "serviceb" {
  grpc_route {
    action {
    }

    match {
    }
  }
}

References

Announcement.
User guide.
API reference.

Requires AWS SDK v1.25.19:

AWS App Mesh roadmap:

Related:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 8, 2019
@ghost ghost added the service/appmesh Issues and PRs that pertain to the appmesh service. label Nov 8, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 8, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Nov 9, 2019
@dominhhai
Copy link

Is any plan to support this?

@hatstand
Copy link
Contributor

aws_appmesh_virtual_node is also affected by this as .spec.listener.port_mapping[].protocol can contain http2 or grpc too now.

@ewbankkit
Copy link
Contributor Author

@hatstand Thanks for noticing that.
I have updated #11669 to add gRPC and HTTP/2 support to aws_appmesh_virtual_node listeners.

@hatstand
Copy link
Contributor

Thanks for adding that to the PR @ewbankkit

@lays147
Copy link

lays147 commented Sep 17, 2020

Hi, aws_appmesh_virtual_router should also support the grpc and http/2 protocols. As I mentioned on issue #15198 =D

@ewbankkit
Copy link
Contributor Author

@lays147 Yes, you are correct. The changes to aws_appmesh_virtual_router have been implemented in the PR that closes this issue, I will change the title of that PR (and update this issue to capture the additional resource).
Thanks.

@breathingdust breathingdust added this to the v3.9.0 milestone Oct 1, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
6 participants