Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Glue Classifier support for CustomDatatypes in CSV Classifiers #27971

Closed
matschundbrei opened this issue Nov 23, 2022 · 5 comments · Fixed by #28048
Closed

[Enhancement]: Glue Classifier support for CustomDatatypes in CSV Classifiers #27971

matschundbrei opened this issue Nov 23, 2022 · 5 comments · Fixed by #28048
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service.
Milestone

Comments

@matschundbrei
Copy link

matschundbrei commented Nov 23, 2022

Description

AWS Glue Classifier does support custom datatypes (i.e. a list of datatypes to be forced on a specific column).

In order to work with CSV classifiers in particular and any classifiers downstream in glue workflows, we would have to be able to easily add them to crawlers. The currently supported format of aws_glue_crawler is to pass a list of names to the parameter classifiers.

Affected Resource(s) and/or Data Source(s)

  • aws_glue_classifier

Potential Terraform Configuration

resource "aws_glue_classifier" "example" {
  name = "example"

  csv_classifier {
    allow_single_column    = false
    contains_header        = "PRESENT"
    delimiter              = ","
    disable_value_trimming = false
    header                 = ["example1", "example2"]
    quote_symbol           = "'"
    custom_datatypes_used  = true
    custom_datatypes       = ["string", "long" ]
  }
}

References

Would you like to implement a fix?

No

@matschundbrei matschundbrei added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Nov 23, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/glue Issues and PRs that pertain to the glue service. label Nov 23, 2022
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Nov 24, 2022
@DrFaust92
Copy link
Collaborator

matschundbrei can i ask you to open a dedicate issue for the new datasource? its usually preferred to have a single change request per ticket/PR

@matschundbrei matschundbrei changed the title [Enhancement]: Glue Classifier support for CustomDatatypes in CSV Classifiers and Datatype for Classifiers [Enhancement]: Glue Classifier support for CustomDatatypes in CSV Classifiers Nov 29, 2022
@matschundbrei
Copy link
Author

relevant parts removed and filed again in #28069

@github-actions github-actions bot added this to the v4.43.0 milestone Nov 29, 2022
@github-actions
Copy link

This functionality has been released in v4.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants