Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: add rate_control_mode attribute to aws_medialive_channel #29051

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Jan 23, 2023

Description

Relations

Closes #28970

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccMediaLiveChannel_' PKG=medialive

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20  -run=TestAccMediaLiveChannel_ -timeout 180m
--- PASS: TestAccMediaLiveChannel_disappears (65.80s)
--- PASS: TestAccMediaLiveChannel_audioDescriptions_codecSettings (66.77s)
--- PASS: TestAccMediaLiveChannel_basic (74.44s)
--- PASS: TestAccMediaLiveChannel_hls (83.42s)
--- PASS: TestAccMediaLiveChannel_updateTags (95.51s)
--- PASS: TestAccMediaLiveChannel_update (117.68s)
--- PASS: TestAccMediaLiveChannel_status (255.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	258.930s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/medialive Issues and PRs that pertain to the medialive service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jan 23, 2023
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Jan 23, 2023
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jan 23, 2023
@johnsonaj johnsonaj marked this pull request as ready for review January 23, 2023 23:20
@johnsonaj johnsonaj merged commit b5c22a9 into main Jan 24, 2023
@johnsonaj johnsonaj deleted the b-aws_medialive_channel_rate_control branch January 24, 2023 15:20
@github-actions github-actions bot added this to the v4.52.0 milestone Jan 24, 2023
github-actions bot pushed a commit that referenced this pull request Jan 24, 2023
@github-actions
Copy link

This functionality has been released in v4.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/medialive Issues and PRs that pertain to the medialive service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: rate_control_mode not expected in aac_settings block of aws_medialive_channel
1 participant