Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add name attribute #33243

Merged

Conversation

tuxpower
Copy link
Contributor

Description

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/efs Issues and PRs that pertain to the efs service. labels Aug 30, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 30, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @tuxpower 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 30, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEFSFileSystemDataSource_\|TestAccEFSFileSystem_' PKG=efs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 3  -run=TestAccEFSFileSystemDataSource_\|TestAccEFSFileSystem_ -timeout 180m
=== RUN   TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== RUN   TestAccEFSFileSystemDataSource_tags
=== PAUSE TestAccEFSFileSystemDataSource_tags
=== RUN   TestAccEFSFileSystemDataSource_name
=== PAUSE TestAccEFSFileSystemDataSource_name
=== RUN   TestAccEFSFileSystemDataSource_availabilityZone
=== PAUSE TestAccEFSFileSystemDataSource_availabilityZone
=== RUN   TestAccEFSFileSystemDataSource_nonExistent_tags
=== PAUSE TestAccEFSFileSystemDataSource_nonExistent_tags
=== RUN   TestAccEFSFileSystem_basic
=== PAUSE TestAccEFSFileSystem_basic
=== RUN   TestAccEFSFileSystem_disappears
=== PAUSE TestAccEFSFileSystem_disappears
=== RUN   TestAccEFSFileSystem_performanceMode
=== PAUSE TestAccEFSFileSystem_performanceMode
=== RUN   TestAccEFSFileSystem_availabilityZoneName
=== PAUSE TestAccEFSFileSystem_availabilityZoneName
=== RUN   TestAccEFSFileSystem_tags
=== PAUSE TestAccEFSFileSystem_tags
=== RUN   TestAccEFSFileSystem_kmsKey
=== PAUSE TestAccEFSFileSystem_kmsKey
=== RUN   TestAccEFSFileSystem_kmsWithoutEncryption
=== PAUSE TestAccEFSFileSystem_kmsWithoutEncryption
=== RUN   TestAccEFSFileSystem_provisionedThroughputInMibps
=== PAUSE TestAccEFSFileSystem_provisionedThroughputInMibps
=== RUN   TestAccEFSFileSystem_throughputMode
=== PAUSE TestAccEFSFileSystem_throughputMode
=== RUN   TestAccEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccEFSFileSystem_lifecyclePolicy
=== CONT  TestAccEFSFileSystemDataSource_id
=== CONT  TestAccEFSFileSystem_availabilityZoneName
=== CONT  TestAccEFSFileSystem_provisionedThroughputInMibps
--- PASS: TestAccEFSFileSystemDataSource_id (51.00s)
=== CONT  TestAccEFSFileSystem_lifecyclePolicy
--- PASS: TestAccEFSFileSystem_availabilityZoneName (59.44s)
=== CONT  TestAccEFSFileSystem_kmsKey
--- PASS: TestAccEFSFileSystem_provisionedThroughputInMibps (93.78s)
=== CONT  TestAccEFSFileSystem_kmsWithoutEncryption
--- PASS: TestAccEFSFileSystem_kmsWithoutEncryption (27.54s)
=== CONT  TestAccEFSFileSystem_tags
--- PASS: TestAccEFSFileSystem_kmsKey (63.13s)
=== CONT  TestAccEFSFileSystem_throughputMode
--- PASS: TestAccEFSFileSystem_throughputMode (94.74s)
=== CONT  TestAccEFSFileSystemDataSource_nonExistent_tags
--- PASS: TestAccEFSFileSystem_lifecyclePolicy (168.19s)
=== CONT  TestAccEFSFileSystem_performanceMode
--- PASS: TestAccEFSFileSystemDataSource_nonExistent_tags (51.30s)
=== CONT  TestAccEFSFileSystem_disappears
--- PASS: TestAccEFSFileSystem_performanceMode (51.37s)
=== CONT  TestAccEFSFileSystem_basic
--- PASS: TestAccEFSFileSystem_tags (191.25s)
=== CONT  TestAccEFSFileSystemDataSource_name
--- PASS: TestAccEFSFileSystem_disappears (46.14s)
=== CONT  TestAccEFSFileSystemDataSource_availabilityZone
--- PASS: TestAccEFSFileSystem_basic (58.64s)
=== CONT  TestAccEFSFileSystemDataSource_tags
--- PASS: TestAccEFSFileSystemDataSource_name (51.43s)
--- PASS: TestAccEFSFileSystemDataSource_availabilityZone (53.95s)
--- PASS: TestAccEFSFileSystemDataSource_tags (48.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	383.478s

@ewbankkit
Copy link
Contributor

@tuxpower Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1b29b6e into hashicorp:main Aug 31, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.15.0 milestone Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/efs Issues and PRs that pertain to the efs service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants