Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_verifiedaccess_instance_trust_provider_attachment #33734

Merged
merged 12 commits into from
Oct 6, 2023
Merged

r/aws_verifiedaccess_instance_trust_provider_attachment #33734

merged 12 commits into from
Oct 6, 2023

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Oct 3, 2023 •
edited
Loading

Description

New resource: aws_verifiedaccess_instance_trust_provider_attachment

Relations

Relates #29689
Closes #33676

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVerifiedAccessTrustProviderAttachment_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVerifiedAccessTrustProviderAttachment_basic -timeout 360m
=== RUN   TestAccVerifiedAccessTrustProviderAttachment_basic
=== PAUSE TestAccVerifiedAccessTrustProviderAttachment_basic
=== CONT  TestAccVerifiedAccessTrustProviderAttachment_basic
--- PASS: TestAccVerifiedAccessTrustProviderAttachment_basic (36.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        36.331s

...

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. labels Oct 3, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 3, 2023
@GlennChia GlennChia force-pushed the f-aws_verifiedaccess_trust_provider_attachment branch from 383a59e to 4ea720c Compare October 3, 2023 05:57
@sQu4rks sQu4rks mentioned this pull request Oct 3, 2023
Merged
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 3, 2023
@ewbankkit ewbankkit self-assigned this Oct 3, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 3, 2023
@ewbankkit
'aws_verifiedaccess_trust_provider_attachment' -> 'aws_verifiedaccess…
041363b 
…_instance_trust_provider_attachment'.
@ewbankkit
Acceptance test output:
b35a92b 
% make testacc TESTARGS='-run=TestAccVerifiedAccessInstanceTrustProviderAttachment_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVerifiedAccessInstanceTrustProviderAttachment_ -timeout 360m
=== RUN   TestAccVerifiedAccessInstanceTrustProviderAttachment_basic
=== PAUSE TestAccVerifiedAccessInstanceTrustProviderAttachment_basic
=== CONT  TestAccVerifiedAccessInstanceTrustProviderAttachment_basic
--- PASS: TestAccVerifiedAccessInstanceTrustProviderAttachment_basic (21.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	26.913s
@ewbankkit
Copy link
Contributor

Renamed to aws_verifiedaccess_instance_trust_provider_attachment - otherwise looking good 👏.

ewbankkit
ewbankkit approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVerifiedAccessInstanceTrustProviderAttachment_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVerifiedAccessInstanceTrustProviderAttachment_ -timeout 360m
=== RUN   TestAccVerifiedAccessInstanceTrustProviderAttachment_basic
=== PAUSE TestAccVerifiedAccessInstanceTrustProviderAttachment_basic
=== RUN   TestAccVerifiedAccessInstanceTrustProviderAttachment_disappears
=== PAUSE TestAccVerifiedAccessInstanceTrustProviderAttachment_disappears
=== CONT  TestAccVerifiedAccessInstanceTrustProviderAttachment_basic
=== CONT  TestAccVerifiedAccessInstanceTrustProviderAttachment_disappears
--- PASS: TestAccVerifiedAccessInstanceTrustProviderAttachment_disappears (20.84s)
--- PASS: TestAccVerifiedAccessInstanceTrustProviderAttachment_basic (23.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	28.612s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@GlennChia GlennChia changed the title r/aws_verifiedaccess_trust_provider_attachment r/aws_verifiedaccess_instance_trust_provider_attachment Oct 5, 2023
@ewbankkit ewbankkit merged commit 5693698 into hashicorp:main Oct 6, 2023
59 checks passed
@github-actions github-actions bot added this to the v5.20.0 milestone Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.20.0
2 participants
@GlennChia @ewbankkit