Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: select_all_options argument for custom_filter_list_configuration and filter_list_configuration not working #33753

Closed
jackarmorgie opened this issue Oct 4, 2023 · 3 comments · Fixed by #33931
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Milestone

Comments

@jackarmorgie
Copy link
Contributor

jackarmorgie commented Oct 4, 2023

Terraform Core Version

1.0.0

AWS Provider Version

5.17.0

Affected Resource(s)

aws_quicksight_dashboard

Expected Behavior

Category filter with select_all_options = "FILTER_ALL_VALUES" to be added to dashboard

Actual Behavior

Dashboard fails to be updated.

Relevant Error/Panic Output Snippet

│ Error: updating Amazon QuickSight Dashboard (123456789012,2a8118f7-b78b-f4ef-be1e-bdb7ed1ef047): InvalidParameterValueException: Category Filter must define only one of: CategoryValue(s), ParameterName, SelectAllOptions,  
│        at Filter 26c74b8a-5543-a6d3-d1ac-587068a3c7f1.
│ {
│   RespMetadata: {
│     StatusCode: 400,
│     RequestID: "cb9e1125-5cea-49e0-9102-be8b1a39cda5"
│   },
│   Message_: "Category Filter must define only one of: CategoryValue(s), ParameterName, SelectAllOptions,  \n\t at Filter 26c74b8a-5543-a6d3-d1ac-587068a3c7f1.",
│   RequestId: "cb9e1125-5cea-49e0-9102-be8b1a39cda5"
│ }
│ 
│   with aws_quicksight_dashboard.example,
│   on quicksight.tf line 220, in resource "aws_quicksight_dashboard" "example":
│  220: resource "aws_quicksight_dashboard" "example" {
│ 
╵

Terraform Configuration Files

resource "aws_quicksight_dashboard" "example" {
    dashboard_id = random_uuid.dashboard_id.result
    name = "example"
    version_description = "example"
    definition {
        data_set_identifiers_declarations {
            ...
        }
        sheets {
            ...
        }
        filter_groups {
            filter_group_id = random_uuid.filter_group_id.result
            filters {
                category_filter {
                    filter_id = random_uuid.filter_id.result
                    column {
                        data_set_identifier = "example"
                        column_name = "product_type"
                    }
                    configuration {
                        filter_list_configuration {
                            match_operator = "CONTAINS"
                            select_all_options = "FILTER_ALL_VALUES"
                        }
                    }
                }
            }
            scope_configuration {
                selected_sheets {
                    sheet_visual_scoping_configurations {
                        sheet_id = random_uuid.sheet_id.result
                        scope = "SELECTED_VISUALS"
                        visual_ids = [
                            random_uuid.visual_id.result,
                        ]
                    }
                }
            }
            cross_dataset = "SINGLE_DATASET"
        }
    }
}

Steps to Reproduce

terraform init
terraform plan
terraform apply

Debug Output

No response

Panic Output

No response

Important Factoids

I think that && len(v) > 0 should be added to this line:

if v, ok := tfMap["category_values"].([]interface{}); ok {

and to this line:

if v, ok := tfMap["category_values"].([]interface{}); ok {

References

No response

Would you like to implement a fix?

Yes

@jackarmorgie jackarmorgie added the bug Addresses a defect in current functionality. label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/quicksight Issues and PRs that pertain to the quicksight service. label Oct 4, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 4, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 25, 2023
@github-actions github-actions bot added this to the v5.26.0 milestone Nov 14, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants