Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(ec2): vpnclient_endpoint_data_source output selfserviceportalurl #34007

Merged

Conversation

kaykhan
Copy link
Contributor

@kaykhan kaykhan commented Oct 19, 2023

Description

Attempting to update the existing datasource to output the SelfServicePortalUrl for aws clientvpn

Relations

Closes #34006

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/ec2_client_vpn_endpoint
https://docs.aws.amazon.com/cli/latest/reference/ec2/describe-client-vpn-endpoints.html

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpnclient Issues and PRs that pertain to the vpnclient service. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 19, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 19, 2023
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 19, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccClientVPNEndpoint_serial/Endpoint_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccClientVPNEndpoint_serial/Endpoint_basic -timeout 180m
=== RUN   TestAccClientVPNEndpoint_serial
=== PAUSE TestAccClientVPNEndpoint_serial
=== CONT  TestAccClientVPNEndpoint_serial
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_basic
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basic
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_basic
--- PASS: TestAccClientVPNEndpoint_serial (0.35s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource (28.88s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basic (31.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	37.663s
% make testacc TESTARGS='-run=TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal -timeout 180m
=== RUN   TestAccClientVPNEndpoint_serial
=== PAUSE TestAccClientVPNEndpoint_serial
=== CONT  TestAccClientVPNEndpoint_serial
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
--- PASS: TestAccClientVPNEndpoint_serial (0.33s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal (47.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	53.322s

@ewbankkit
Copy link
Contributor

@kaykhan Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a488c3e into hashicorp:main Oct 19, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.22.0 milestone Oct 19, 2023
@github-actions
Copy link

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/vpnclient Issues and PRs that pertain to the vpnclient service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: EC2 VPN Client Endpoint Datasource Output SelfServicePortalUrl
2 participants