-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(ec2): vpnclient_endpoint_data_source output selfserviceportalurl #34007
update(ec2): vpnclient_endpoint_data_source output selfserviceportalurl #34007
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccClientVPNEndpoint_serial/Endpoint_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccClientVPNEndpoint_serial/Endpoint_basic -timeout 180m
=== RUN TestAccClientVPNEndpoint_serial
=== PAUSE TestAccClientVPNEndpoint_serial
=== CONT TestAccClientVPNEndpoint_serial
=== RUN TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== RUN TestAccClientVPNEndpoint_serial/Endpoint_basic
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basic
=== CONT TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== CONT TestAccClientVPNEndpoint_serial/Endpoint_basic
--- PASS: TestAccClientVPNEndpoint_serial (0.35s)
--- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource (28.88s)
--- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basic (31.98s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 37.663s
% make testacc TESTARGS='-run=TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal -timeout 180m
=== RUN TestAccClientVPNEndpoint_serial
=== PAUSE TestAccClientVPNEndpoint_serial
=== CONT TestAccClientVPNEndpoint_serial
=== RUN TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== CONT TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal
--- PASS: TestAccClientVPNEndpoint_serial (0.33s)
--- PASS: TestAccClientVPNEndpoint_serial/Endpoint_selfServicePortal (47.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 53.322s
@kaykhan Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Attempting to update the existing datasource to output the
SelfServicePortalUrl
for aws clientvpnRelations
Closes #34006
References
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/ec2_client_vpn_endpoint
https://docs.aws.amazon.com/cli/latest/reference/ec2/describe-client-vpn-endpoints.html
Output from Acceptance Testing