Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finspace: Increase kx_cluster create/update and kx_environment delete timeouts #34398

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

kavan-aws
Copy link
Contributor

@kavan-aws kavan-aws commented Nov 14, 2023

Description

Increases create and update default timeouts of kx_cluster resource to 18 hours to prepare for upcoming changes involving cache warming.

Also increase delete default timeout of kx_environment resource to 75 minutes to prepare for bug fix coming to deletion workflow when environment has deleting clusters (as in acceptance tests).

Relations

Relates #33745 and #31806

Output from Acceptance Testing

Fix on cluster/environment deletion still in progress for kx_cluster tests, but ran TestAccFinSpaceKxCluster_code after making timeout changes and verified that create and update both worked as expected, along with their checks. Will rerun all cluster tests once deletion bug is fixed.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. service/finspace Issues and PRs that pertain to the finspace service. labels Nov 14, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Nov 14, 2023
@kavan-aws kavan-aws changed the title finspace_kx_cluster: Increase create and update timeouts finspace: Increase kx_cluster create/update and kx_environment delete timeouts Nov 14, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Nov 14, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jar-b jar-b merged commit 8fd1d9b into hashicorp:main Nov 16, 2023
40 checks passed
@github-actions github-actions bot added this to the v5.26.0 milestone Nov 16, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/finspace Issues and PRs that pertain to the finspace service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants