-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSx ONTAP FlexGroup and Scale-out update #36511
FSx ONTAP FlexGroup and Scale-out update #36511
Conversation
Community NoteVoting for Prioritization
For Submitters
|
… This property is deprecated, use SizeInBytes instead (staticcheck)'.
…eIntBetween': int64 arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
--- PASS: TestAccFSxFileCache_serial (8402.00s)
--- PASS: TestAccFSxFileCache_serial/FSxFileCache (8402.00s)
--- PASS: TestAccFSxFileCache_serial/FSxFileCache/copy_tags_to_data_repository_associations (836.19s)
--- PASS: TestAccFSxFileCache_serial/FSxFileCache/data_repository_association_multiple (1037.45s)
--- PASS: TestAccFSxFileCache_serial/FSxFileCache/data_repository_association_nfs (997.01s)
--- PASS: TestAccFSxFileCache_serial/FSxFileCache/tags (893.33s)
--- PASS: TestAccFSxFileCache_serial/FSxFileCache/basic (995.49s)
--- PASS: TestAccFSxFileCache_serial/FSxFileCache/disappears (808.16s)
--- PASS: TestAccFSxFileCache_serial/FSxFileCache/kms_key_id (1943.20s)
--- PASS: TestAccFSxFileCache_serial/FSxFileCache/data_repository_association_s3 (842.24s)
--- PASS: TestAccFSxFileCache_serial/FSxFileCache/security_group_id (1071.02s)
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxBackup_' PKG=fsx ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/fsx/... -v -count 1 -parallel 3 -run=TestAccFSxBackup_ -timeout 720m
=== RUN TestAccFSxBackup_basic
=== PAUSE TestAccFSxBackup_basic
=== RUN TestAccFSxBackup_ontapBasic
=== PAUSE TestAccFSxBackup_ontapBasic
=== RUN TestAccFSxBackup_openzfsBasic
=== PAUSE TestAccFSxBackup_openzfsBasic
=== RUN TestAccFSxBackup_windowsBasic
=== PAUSE TestAccFSxBackup_windowsBasic
=== RUN TestAccFSxBackup_disappears
=== PAUSE TestAccFSxBackup_disappears
=== RUN TestAccFSxBackup_Disappears_filesystem
=== PAUSE TestAccFSxBackup_Disappears_filesystem
=== RUN TestAccFSxBackup_tags
=== PAUSE TestAccFSxBackup_tags
=== RUN TestAccFSxBackup_implicitTags
=== PAUSE TestAccFSxBackup_implicitTags
=== CONT TestAccFSxBackup_basic
=== CONT TestAccFSxBackup_disappears
=== CONT TestAccFSxBackup_tags
--- PASS: TestAccFSxBackup_tags (746.08s)
=== CONT TestAccFSxBackup_Disappears_filesystem
--- PASS: TestAccFSxBackup_disappears (763.74s)
=== CONT TestAccFSxBackup_implicitTags
--- PASS: TestAccFSxBackup_basic (828.32s)
=== CONT TestAccFSxBackup_windowsBasic
--- PASS: TestAccFSxBackup_implicitTags (664.86s)
=== CONT TestAccFSxBackup_openzfsBasic
--- PASS: TestAccFSxBackup_Disappears_filesystem (772.86s)
=== CONT TestAccFSxBackup_ontapBasic
--- PASS: TestAccFSxBackup_openzfsBasic (652.65s)
--- PASS: TestAccFSxBackup_ontapBasic (3238.96s)
--- PASS: TestAccFSxBackup_windowsBasic (3962.19s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 4801.251s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxOpenZFSSnapshot' PKG=fsx ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/fsx/... -v -count 1 -parallel 3 -run=TestAccFSxOpenZFSSnapshot -timeout 720m
=== RUN TestAccFSxOpenZFSSnapshotDataSource_basic
=== PAUSE TestAccFSxOpenZFSSnapshotDataSource_basic
=== RUN TestAccFSxOpenZFSSnapshot_basic
=== PAUSE TestAccFSxOpenZFSSnapshot_basic
=== RUN TestAccFSxOpenZFSSnapshot_disappears
=== PAUSE TestAccFSxOpenZFSSnapshot_disappears
=== RUN TestAccFSxOpenZFSSnapshot_tags
=== PAUSE TestAccFSxOpenZFSSnapshot_tags
=== RUN TestAccFSxOpenZFSSnapshot_name
=== PAUSE TestAccFSxOpenZFSSnapshot_name
=== RUN TestAccFSxOpenZFSSnapshot_childVolume
=== PAUSE TestAccFSxOpenZFSSnapshot_childVolume
=== RUN TestAccFSxOpenZFSSnapshot_volumeID
=== PAUSE TestAccFSxOpenZFSSnapshot_volumeID
=== CONT TestAccFSxOpenZFSSnapshotDataSource_basic
=== CONT TestAccFSxOpenZFSSnapshot_disappears
=== CONT TestAccFSxOpenZFSSnapshot_name
--- PASS: TestAccFSxOpenZFSSnapshot_disappears (678.38s)
=== CONT TestAccFSxOpenZFSSnapshot_volumeID
--- PASS: TestAccFSxOpenZFSSnapshotDataSource_basic (839.27s)
=== CONT TestAccFSxOpenZFSSnapshot_childVolume
--- PASS: TestAccFSxOpenZFSSnapshot_name (903.50s)
=== CONT TestAccFSxOpenZFSSnapshot_basic
--- PASS: TestAccFSxOpenZFSSnapshot_childVolume (858.82s)
=== CONT TestAccFSxOpenZFSSnapshot_tags
--- PASS: TestAccFSxOpenZFSSnapshot_volumeID (1023.66s)
--- PASS: TestAccFSxOpenZFSSnapshot_basic (813.39s)
--- PASS: TestAccFSxOpenZFSSnapshot_tags (754.23s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 2428.344s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxONTAPFileSystem_' PKG=fsx ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/fsx/... -v -count 1 -parallel 3 -run=TestAccFSxONTAPFileSystem_ -timeout 720m
=== RUN TestAccFSxONTAPFileSystem_basic
=== PAUSE TestAccFSxONTAPFileSystem_basic
=== RUN TestAccFSxONTAPFileSystem_singleAZ
=== PAUSE TestAccFSxONTAPFileSystem_singleAZ
=== RUN TestAccFSxONTAPFileSystem_haPair
=== PAUSE TestAccFSxONTAPFileSystem_haPair
=== RUN TestAccFSxONTAPFileSystem_fsxAdminPassword
=== PAUSE TestAccFSxONTAPFileSystem_fsxAdminPassword
=== RUN TestAccFSxONTAPFileSystem_endpointIPAddressRange
=== PAUSE TestAccFSxONTAPFileSystem_endpointIPAddressRange
=== RUN TestAccFSxONTAPFileSystem_diskIOPS
=== PAUSE TestAccFSxONTAPFileSystem_diskIOPS
=== RUN TestAccFSxONTAPFileSystem_disappears
=== PAUSE TestAccFSxONTAPFileSystem_disappears
=== RUN TestAccFSxONTAPFileSystem_securityGroupIDs
=== PAUSE TestAccFSxONTAPFileSystem_securityGroupIDs
=== RUN TestAccFSxONTAPFileSystem_routeTableIDs
=== PAUSE TestAccFSxONTAPFileSystem_routeTableIDs
=== RUN TestAccFSxONTAPFileSystem_tags
=== PAUSE TestAccFSxONTAPFileSystem_tags
=== RUN TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime
=== RUN TestAccFSxONTAPFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxONTAPFileSystem_automaticBackupRetentionDays
=== RUN TestAccFSxONTAPFileSystem_kmsKeyID
=== PAUSE TestAccFSxONTAPFileSystem_kmsKeyID
=== RUN TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime
=== RUN TestAccFSxONTAPFileSystem_throughputCapacity
=== PAUSE TestAccFSxONTAPFileSystem_throughputCapacity
=== RUN TestAccFSxONTAPFileSystem_storageCapacity
=== PAUSE TestAccFSxONTAPFileSystem_storageCapacity
=== CONT TestAccFSxONTAPFileSystem_basic
=== CONT TestAccFSxONTAPFileSystem_routeTableIDs
=== CONT TestAccFSxONTAPFileSystem_endpointIPAddressRange
--- PASS: TestAccFSxONTAPFileSystem_basic (2573.29s)
=== CONT TestAccFSxONTAPFileSystem_haPair
--- PASS: TestAccFSxONTAPFileSystem_endpointIPAddressRange (2714.54s)
=== CONT TestAccFSxONTAPFileSystem_fsxAdminPassword
--- PASS: TestAccFSxONTAPFileSystem_routeTableIDs (2848.61s)
=== CONT TestAccFSxONTAPFileSystem_singleAZ
--- PASS: TestAccFSxONTAPFileSystem_singleAZ (2601.67s)
=== CONT TestAccFSxONTAPFileSystem_disappears
--- PASS: TestAccFSxONTAPFileSystem_fsxAdminPassword (2750.28s)
=== CONT TestAccFSxONTAPFileSystem_securityGroupIDs
--- PASS: TestAccFSxONTAPFileSystem_haPair (4790.02s)
=== CONT TestAccFSxONTAPFileSystem_kmsKeyID
--- PASS: TestAccFSxONTAPFileSystem_disappears (2803.15s)
=== CONT TestAccFSxONTAPFileSystem_storageCapacity
--- PASS: TestAccFSxONTAPFileSystem_kmsKeyID (2672.01s)
=== CONT TestAccFSxONTAPFileSystem_throughputCapacity
--- PASS: TestAccFSxONTAPFileSystem_storageCapacity (2669.81s)
=== CONT TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccFSxONTAPFileSystem_securityGroupIDs (5501.63s)
=== CONT TestAccFSxONTAPFileSystem_diskIOPS
--- PASS: TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime (2800.20s)
=== CONT TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime
--- PASS: TestAccFSxONTAPFileSystem_diskIOPS (2792.48s)
=== CONT TestAccFSxONTAPFileSystem_automaticBackupRetentionDays
--- PASS: TestAccFSxONTAPFileSystem_throughputCapacity (4447.27s)
=== CONT TestAccFSxONTAPFileSystem_tags
--- PASS: TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime (2850.38s)
--- PASS: TestAccFSxONTAPFileSystem_automaticBackupRetentionDays (2923.97s)
--- PASS: TestAccFSxONTAPFileSystem_tags (2834.64s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 17327.550s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxONTAPVolume_' PKG=fsx ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/fsx/... -v -count 1 -parallel 3 -run=TestAccFSxONTAPVolume_ -timeout 720m
=== RUN TestAccFSxONTAPVolume_basic
=== PAUSE TestAccFSxONTAPVolume_basic
=== RUN TestAccFSxONTAPVolume_disappears
=== PAUSE TestAccFSxONTAPVolume_disappears
=== RUN TestAccFSxONTAPVolume_aggregateConfiguration
=== PAUSE TestAccFSxONTAPVolume_aggregateConfiguration
=== RUN TestAccFSxONTAPVolume_copyTagsToBackups
=== PAUSE TestAccFSxONTAPVolume_copyTagsToBackups
=== RUN TestAccFSxONTAPVolume_junctionPath
=== PAUSE TestAccFSxONTAPVolume_junctionPath
=== RUN TestAccFSxONTAPVolume_name
=== PAUSE TestAccFSxONTAPVolume_name
=== RUN TestAccFSxONTAPVolume_ontapVolumeType
=== PAUSE TestAccFSxONTAPVolume_ontapVolumeType
=== RUN TestAccFSxONTAPVolume_securityStyle
=== PAUSE TestAccFSxONTAPVolume_securityStyle
=== RUN TestAccFSxONTAPVolume_size
=== PAUSE TestAccFSxONTAPVolume_size
=== RUN TestAccFSxONTAPVolume_snaplock
=== PAUSE TestAccFSxONTAPVolume_snaplock
=== RUN TestAccFSxONTAPVolume_snapshotPolicy
=== PAUSE TestAccFSxONTAPVolume_snapshotPolicy
=== RUN TestAccFSxONTAPVolume_storageEfficiency
=== PAUSE TestAccFSxONTAPVolume_storageEfficiency
=== RUN TestAccFSxONTAPVolume_tags
=== PAUSE TestAccFSxONTAPVolume_tags
=== RUN TestAccFSxONTAPVolume_tieringPolicy
=== PAUSE TestAccFSxONTAPVolume_tieringPolicy
=== RUN TestAccFSxONTAPVolume_volumeStyle
=== PAUSE TestAccFSxONTAPVolume_volumeStyle
=== CONT TestAccFSxONTAPVolume_basic
=== CONT TestAccFSxONTAPVolume_size
=== CONT TestAccFSxONTAPVolume_junctionPath
--- PASS: TestAccFSxONTAPVolume_basic (3008.21s)
=== CONT TestAccFSxONTAPVolume_tags
--- PASS: TestAccFSxONTAPVolume_junctionPath (3439.73s)
=== CONT TestAccFSxONTAPVolume_volumeStyle
--- PASS: TestAccFSxONTAPVolume_size (4764.78s)
=== CONT TestAccFSxONTAPVolume_tieringPolicy
--- PASS: TestAccFSxONTAPVolume_tags (3116.76s)
=== CONT TestAccFSxONTAPVolume_ontapVolumeType
--- PASS: TestAccFSxONTAPVolume_volumeStyle (3037.38s)
=== CONT TestAccFSxONTAPVolume_securityStyle
--- PASS: TestAccFSxONTAPVolume_tieringPolicy (3651.25s)
=== CONT TestAccFSxONTAPVolume_name
--- PASS: TestAccFSxONTAPVolume_ontapVolumeType (2957.95s)
=== CONT TestAccFSxONTAPVolume_aggregateConfiguration
--- PASS: TestAccFSxONTAPVolume_securityStyle (3697.53s)
=== CONT TestAccFSxONTAPVolume_copyTagsToBackups
--- PASS: TestAccFSxONTAPVolume_name (3618.10s)
=== CONT TestAccFSxONTAPVolume_snapshotPolicy
--- PASS: TestAccFSxONTAPVolume_copyTagsToBackups (3442.35s)
=== CONT TestAccFSxONTAPVolume_storageEfficiency
--- PASS: TestAccFSxONTAPVolume_aggregateConfiguration (4985.29s)
=== CONT TestAccFSxONTAPVolume_disappears
--- PASS: TestAccFSxONTAPVolume_snapshotPolicy (3363.92s)
=== CONT TestAccFSxONTAPVolume_snaplock
--- PASS: TestAccFSxONTAPVolume_storageEfficiency (3201.21s)
--- PASS: TestAccFSxONTAPVolume_disappears (3062.62s)
--- PASS: TestAccFSxONTAPVolume_snaplock (3068.61s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 18477.144s
@awsaxeman Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This update included changes for fsx_ontap_file_system and fsx_ontap_volume. the fsx_ontap_file_system has includes updates to the size of clusters for scale-out clusters to match the new limits and allowing using the ha_pairs and throughput_per_ha_pair with scale-up clusters. Some customers want to be able to do that for consistency in their configs between scale-out and scale-up and it is supported by the FSx API. For volumes this update adds support for FLEXGROUP type volumes which also relates to scale-out clusters and allow much larger capacity (up to 20PB).
Relations
Closes #36389
Closes #36465
References
https://docs.aws.amazon.com/fsx/latest/APIReference/API_OntapVolumeConfiguration.html
https://docs.aws.amazon.com/fsx/latest/APIReference/API_OntapFileSystemConfiguration.html
Output from Acceptance Testing