Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_ssm_patch_group can not contain multiple patch baselines #37622

Closed
tknisch opened this issue May 21, 2024 · 5 comments · Fixed by #37626
Closed

[Bug]: aws_ssm_patch_group can not contain multiple patch baselines #37622

tknisch opened this issue May 21, 2024 · 5 comments · Fixed by #37626
Assignees
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ssm Issues and PRs that pertain to the ssm service.
Milestone

Comments

@tknisch
Copy link

tknisch commented May 21, 2024

Terraform Core Version

1.7.5

AWS Provider Version

5.50.0

Affected Resource(s)

aws_ssm_patch_group

Expected Behavior

If using the aws_ssm_patch_group with a for_each in version 5.49.0 and before multiple baselines were added to the patchgroup:

image

Actual Behavior

With version 5.50.0 only one baseline is assigned to the patch group:

image

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

locals {
  patchgroup_name = "my-Default-PatchGroup"
  os = [
    "AMAZON_LINUX",
    "AMAZON_LINUX_2",
    "AMAZON_LINUX_2022",
    "AMAZON_LINUX_2023",
    "UBUNTU",
    "DEBIAN",
    "RASPBIAN",
    "REDHAT_ENTERPRISE_LINUX",
    "CENTOS",
    "ORACLE_LINUX",
    "SUSE",
    "ROCKY_LINUX",
    "ALMA_LINUX",
    "WINDOWS"
  ]
}


data "aws_ssm_patch_baseline" "all" {
  for_each         = toset(local.os)
  operating_system = each.value
  owner            = "AWS"
  default_baseline = true
}


resource "aws_ssm_patch_group" "my_patchgroup" {
  for_each    = data.aws_ssm_patch_baseline.all
  baseline_id = each.value.id
  patch_group = local.patchgroup_name
}

Steps to Reproduce

Run code with aws provider version 5.49.0 or before and then upgrade to 5.50.0 and apply

Debug Output

image

Panic Output

No response

Important Factoids

No response

References

#37481

Would you like to implement a fix?

No

@tknisch tknisch added the bug Addresses a defect in current functionality. label May 21, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/ssm Issues and PRs that pertain to the ssm service. label May 21, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 21, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 21, 2024
@ewbankkit ewbankkit self-assigned this May 21, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 21, 2024
@ewbankkit
Copy link
Contributor

The bug is in the aws_ssm_patch_baseline data source's handling of the default_baseline argument.
We will fix for this week's release.

@ewbankkit ewbankkit added the regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. label May 21, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.51.0 milestone May 21, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 24, 2024
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants