Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudfront parameter to NOT wait for distribution to finish deploying #8175

Closed
t-pascal opened this issue Apr 3, 2019 · 3 comments
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service.
Milestone

Comments

@t-pascal
Copy link

t-pascal commented Apr 3, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In #260 the feature was to change the default behavior for deploying cloudfront to wait until the distribution is completely deployed. This takes approximately 8-20 minutes. Unfortunately, we have a dozen cloudfront terraforms that we manage and our deployment pipline which used to complete in a few minutes now delays and waits an intolerable amount of time.

I feel like changing the default was a reasonable decision, but the option to restore the previous behavior (without locking our provider version) would be a welcome feature.

New or Affected Resource(s)

  • aws_cloudfront_distribution

Potential Terraform Configuration

resource "aws_cloudfront_distribution" "consumer_traffic" {
  aliases             = ["${split(",",var.alternate_domain_names)}"]
  comment             = "Consumer Frontend - ${var.distribution_name}"
  default_root_object = ""
  price_class         = "PriceClass_100"
  enabled             = true
  wait_for_deployment = false
…
}

References

@t-pascal t-pascal added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 3, 2019
@bflad bflad added the service/cloudfront Issues and PRs that pertain to the cloudfront service. label Apr 3, 2019
@bflad
Copy link
Contributor

bflad commented Apr 3, 2019

Hi @t-pascal 👋 Thanks for submitting this. Good news, support for a new argument to disable the behavior, wait_for_deployment, has been merged via #8116 and will release later this week with version 2.5.0 of the Terraform AWS Provider. Since this is already completed and just pending release I'm going to close this issue. 👍

@bflad bflad closed this as completed Apr 3, 2019
@bflad bflad added this to the v2.5.0 milestone Apr 3, 2019
@rtlong
Copy link

rtlong commented Apr 3, 2019

See also #8073

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service.
Projects
None yet
Development

No branches or pull requests

3 participants